Expensify
Expense-Delete and replace options displayed for receipt in archived workspace offline
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.47-1 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/50395 Issue reported by: Applause Internal Team
Action Performed:
- Open the app and log in
- Navigate to a workspace chat
- Disable internet connection
- Create an expense with a receipt
- Navigate to the list of workspaces and delete the workspace
- Open the archived workspace chat
- Select the expense > tap 3 dots
Expected Result:
The "Delete" and "Replace" options should not be present
Actual Result:
The "Delete" and "Replace" options are displayed when the workspace is deleted offline
Workaround:
Unknown
Platforms:
- [x] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/ab81d261-f065-4c24-807a-176a8fecba71
Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I will take a look very soon. It's related to my PR so we don't need proposals here.
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?
Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Hey @johncschuster! I'm heading out on parental leave so reassigning this! TY! 🙇♂️
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Sorry for delay, I have couple of urgent PR's left to finish, I will probably finish this one tomorrow.
@johncschuster @Krishna2323 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@Krishna2323 how's this one going? Were you able to get a PR up for this?
@johncschuster, I'm not sure about the expected behavior. In this PR, I made the change to not display the options because none of the fields of the expense were editable. When we were trying to replace the receipt, the "not here" page was shown. However, it looks like the behavior has changed, now we can replace the receipt and edit the fields of an expense in an archived workspace and it's also supported by the backend.
Offline behaviour
https://github.com/user-attachments/assets/63ae8e60-eca6-4897-9a24-8ca0ba64906a
Online behaviour
https://github.com/user-attachments/assets/eb26d417-6b26-458d-a4a3-38e4aeb7b1b0
cc: @suneox
Thanks for your comment, @Krishna2323! Let me review this with fresh eyes in the morning.
@johncschuster, @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Ok! I'm back. @Krishna2323 I'm not quite sure if it's intended to delete and replace the receipt image for an archived expense. I'll need to check on that on Monday.
I didn't get to dig into this today. I should have some more time tomorrow!
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
I'm catching up from being OOO for the holiday last week. Will get this slotted in tomorrow.
@johncschuster, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!