Fix - Chat - Compose box stays in the middle when reduced with a several lines message

[FitseTLT]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49541 PROPOSAL: https://github.com/Expensify/App/issues/49541#issuecomment-2364519871

Tests

1. Open the staging.new.expensify.com website.
2. Open any chat.
3. On compose box, start writing a message adding new lines until a scrollbar can be seen.
4. Tap on the "Expand" button.
5. Keep adding lines to the message until a scrollbar can also be seen with the compose box expanded.
6. Reduce the compose box size.
7. Verify that the compose is scrolled to the bottom

• [x] Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/1f8475f0-de18-4738-a494-240b77954f81

Android: mWeb Chrome

https://github.com/user-attachments/assets/3f3b74bc-edc4-428e-ab99-65f6aff38c00

iOS: Native

https://github.com/user-attachments/assets/ed71eb80-89fa-4034-9721-05f1acea4489

iOS: mWeb Safari

https://github.com/user-attachments/assets/f7de09d7-c248-4be5-8f2d-0112c8174029

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/37f6d1ff-12fd-4a8d-b283-c27ef8694a70

MacOS: Desktop

https://github.com/user-attachments/assets/f6d095d2-d2ff-4037-a227-9e0654acb3d9

[melvin-bot[bot]]

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[FitseTLT]

still working on native behaviour 👍

[rayane-d]

@FitseTLT Any update?

[FitseTLT]

@rayane-djouah, I am having difficulty scrolling the text input imperatively on native, unlike the web case. There is neither scrollTo function nor scrollTop prop to set on the ref. Do you have any suggestions?

[rayane-d]

Will check on my end and let you know

[rayane-d]

@FitseTLT The bug reported in https://github.com/Expensify/App/issues/49541#issue-2539081948 is not reproducible on native platforms. Therefore, I believe we should maintain the current behavior for native.

[FitseTLT]

But @rayane-djouah I am seeing the same problem as the OP in IOS, for instance,

https://github.com/user-attachments/assets/53147903-31c3-4e61-9cad-cc5b108a1105

[rayane-d]

Oh, so this bug is specific to iOS native? Then we need to find a solution for it.

[FitseTLT]

@rayane-djouah I have managed to scroll to cursor position, to indirectly solve the problem on native. Look at the results, I have now uploaded the native screenshots in OP, and let me know your opinion.

[rayane-d]

@FitseTLT Jest tests and performance tests are failing

[FitseTLT]

@rayane-djouah Tests fixed

[rayane-d]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/5d678a9f-cac4-4ce6-8d75-b870bbcc467b

Android: mWeb Chrome

https://github.com/user-attachments/assets/24f5b962-e564-4372-85f1-2dc355ef89df

iOS: Native

https://github.com/user-attachments/assets/cbf2732e-8df8-4613-a4d3-ce6406061a97

iOS: mWeb Safari

https://github.com/user-attachments/assets/03db6b93-9482-480b-8833-1e051e47dbfb

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/6da3d0ca-d168-48f0-8c41-305978e89f27

MacOS: Desktop

https://github.com/user-attachments/assets/fd7ae4f7-4f2c-42bf-9842-b6eac5e1558e

[rayane-d]

@FitseTLT The solution is not working for me on iOS native:

https://github.com/user-attachments/assets/01b54e35-ed9a-44d7-8a94-7e43567c391d

[FitseTLT]

Fixed I suspect it is related with regression caused by the bridge less pr solved it by giving some delay

https://github.com/user-attachments/assets/30f30213-504f-4d00-b332-67fe08608d58

[FitseTLT]

Hey @rayane-djouah I have been exploring how to programmatically scroll text inputs on natives and I found that we need to add scroll view for android, for instance, here So I think there couldn't be any other workaround in react native and experimented the possibility of it but as you take the scrolling ability of the text input to the the scroll view you lose the auto grow behaviour of the text input and also there could be other side effects. Moreover, it wouldn't make sense to apply this kind of workaround considering the importance of the original bug. It looks like I am running out of ideas now but fortunately, the problem only exists on IOS (assuming Android scrolls to the cursor by default) so I hand it to you for any decision on how to move forward. Thx!

[rayane-d]

@FitseTLT I will post an update today, could you please resolve the conflicts meanwhile? Thanks!

[FitseTLT]

@rayane-djouah resolved

[rayane-d]

@Expensify/design We've addressed the issue as detailed in this comment. However, due to platform constraints on iOS native, we're unable to directly align the scroll position to the bottom of the composer bar, it's always aligned to the top by default. As a workaround, we've implemented a solution to programmatically scroll the input, which introduces a scrolling animation. Could you please review the two videos comparing the behavior before and after the fix? We would like your feedback on whether the scrolling animation is acceptable.

Current iOS app behavior	Behavior after the fix

[dannymcclain]

It feels a little teeny tiny bit weird to me, but I think I still prefer it over losing visibility of my cursor. Keen for the other designers to weigh in.

[shawnborton]

Yup, I agree with that. Feels like an improvement for sure though!

[dubielzyk-expensify]

Agree with you both

[rayane-d]

@FitseTLT There are merge conflicts

[FitseTLT]

Resolved @rayane-djouah

[OSBotify]

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions[bot]]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions[bot]]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions[bot]]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌