[Workspace Feeds] Remove confirmation step for adding a bank account in broader VBBA flow.

[kevinksullivan]

Background

thread

We're showing a "double check to make sure everything is right" screen after someone adds a bank account, which is only a single action. This makes the step of choosing an account and then confirming that account right after redundant.

Action performed

1. Sign up with gmail account added to Workspace feeds beta
2. Enable Expensify Card in more features
3. Select Issue card to kick off the enablement flow
4. Add a test bank account setup using credentials from option 3 in the SO

Expected behavior

No additional confirmation screen after immediately adding the bank account

Actual behavior

We show a confirmation screen right after adding the account.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021832130991616168173
• Upwork Job ID: 1832130991616168173
• Last Price Increase: 2024-09-06
• Automatic offers:
• ishpaul777 | Contributor | 103858796

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021832130991616168173

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[trjExpensify]

Going to take Help wanted off this for a second, as we have peeps working on the project.

[melvin-bot[bot]]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Payment will be handled at https://github.com/Expensify/App/issues/48732 once done

[parasharrajat]

There are two flows here, Manual and plaid. Do I have to remove it from both @mountiny?

[mountiny]

@parasharrajat yeah lets remove the confirmation page from both

[parasharrajat]

@mountiny I noticed that we disable fields on manual step once they are added and user moved to next step. Should these remain editable when use go back previous step?

[mountiny]

@parasharrajat Not sure if I follow but I would say that if the user goes back in the form flow, the fields should be editable

[trjExpensify]

Updated the titles to reflect the payment date. PR hit prod 4 days ago.

[trjExpensify]

Payment summary as follows:

• $250 to @parasharrajat for the fix
• $250 to @ishpaul777 for the C+ review

Rajat, go ahead and request. @ishpaul777, please accept the pending offer.

[ishpaul777]

Accepted!

Edit: There was 2 offers made by melvin, I accepted both by mistake one needs to retracted https://github.com/Expensify/App/issues/48730#issuecomment-2335268720 and https://github.com/Expensify/App/issues/48730#issuecomment-2335268740

[parasharrajat]

@trjExpensify Please close this issue when done. I will request later. Thanks.

[parasharrajat]

Payment requested as per https://github.com/Expensify/App/issues/48730#issuecomment-2384266447

[melvin-bot[bot]]

@trjExpensify @parasharrajat @mountiny @ishpaul777 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[trjExpensify]

Paid, closing!

[JmillsExpensify]

$250 approved for @parasharrajat