App
App copied to clipboard
Expensify
[$125] Upgrade mapbox and remove patch
This issue is just a tracker to upgrade mapbox and remove the patch we added in https://github.com/Expensify/App/pull/45289/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R102
Looks like the build issues are being address upstream in https://github.com/rnmapbox/maps/issues/3593 and we can upgrade to https://github.com/rnmapbox/maps/releases/tag/v10.1.30 and remove the patch.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ed1b0e1397924f45
- Upwork Job ID: 1828535807455065976
- Last Price Increase: 2024-08-27
- Automatic offers:
- suneox | Reviewer | 103729434
- abzokhattab | Contributor | 103729436
Issue Owner
Current Issue Owner: @suneox
Job added to Upwork: https://www.upwork.com/jobs/~01ed1b0e1397924f45
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)
Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
For the sake of this proposal, let's lay out the test steps we'll follow to ensure that the new version works as expected
Edited by proposal-police: This proposal was edited at 2024-08-27 22:21:47 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Upgrade mapbox and remove patch
What is the root cause of that problem?
The root cause is a compatibility issue between React Native 0.75 and the @rnmapbox/maps package version 10.1.26. A patch was initially applied to address these issues, but the underlying problems are being addressed upstream in rnmapbox/maps by the maintainers so we can remove this patch and upgrade the package instead .
What changes do you think we should make in order to solve the problem?
Upgrade the @rnmapbox/maps package to version 10.1.30, which includes fixes for the React Native 0.75 compatibility issues, and remove the old patch previously applied to this package.
What alternative solutions did you explore? (Optional)
N.A.
@abzokhattab proposal is straightforward to handle the update, so we can go ahead with it.
🎀 👀 🎀 C+ reviewed
Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@suneox, @lschurr, @roryabraham, @abzokhattab Eep! 4 days overdue now. Issues have feelings too...
@suneox, @lschurr, @roryabraham, @abzokhattab Whoops! This issue is 2 days overdue. Let's get this updated quick!
Thanks for your patience i was having a problem upgrading Ruby from v2 to v4 .. the PR is now ready
Sorry for the difficulty with automations not working in this case. Growing pains in the deploy systems.
The PR for this was deployed to prod on 2024-09-11
Which PR fixed the bug on this GH @roryabraham?
It looks like this one wasn't deployed to prod yet: https://github.com/Expensify/App/pull/48436
https://github.com/Expensify/App/pull/48436. It was deployed to prod on 2024-09-11, the deploy comment just didn't work. Sorry for the confusion
Payment summary:
- Contributor: @abzokhattab $125 (paid in Upwork)
- Reviewer: @suneox $125 (paid in Upwork)