feat: add labels to bottom tab bar

[BhuvaneshPatil]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/47339 PROPOSAL: https://github.com/Expensify/App/issues/47339#issuecomment-2286559311

Tests

• [ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

• [ ] Verify that no errors appear in the JS console

PR Author Checklist

• [ ] I linked the correct issue in the ### Fixed Issues section above
• [ ] I wrote clear testing steps that cover the changes made in this PR
  • [ ] I added steps for local testing in the Tests section
  • [ ] I added steps for the expected offline behavior in the Offline steps section
  • [ ] I added steps for Staging and/or Production testing in the QA steps section
  • [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [ ] I included screenshots or videos for tests on all platforms
• [ ] I ran the tests on all platforms & verified they passed on:
  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop
• [ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [ ] I followed proper code patterns (see Reviewing the code)
  • [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [ ] I verified that comments were added to code that is not self explanatory
  • [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [ ] I followed the guidelines as stated in the Review Guidelines
• [ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [ ] I verified that if a function's arguments changed that all usages have also been updated correctly
• [ ] If any new file was added I verified that:
  • [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [ ] If a new CSS style is added I verified that:
  • [ ] A similar style doesn't already exist
  • [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [ ] I verified that all the inputs inside a form are aligned with each other.
  • [ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot[bot]]

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[BhuvaneshPatil]

Android Browser -

[BhuvaneshPatil]

android native-

[BhuvaneshPatil]

IOS Native -

[BhuvaneshPatil]

[BhuvaneshPatil]

@rushatgabhane I have not completed checklist yet because we might need to change code based on feedback from design team

[rushatgabhane]

Makes sense

[rushatgabhane]

@Expensify/design

We need your feedback on the design - https://github.com/Expensify/App/pull/48003#issuecomment-2310329673

[shawnborton]

So we need to adjust the gap between icon + label so that all of the labels line up perfectly. See the big difference here?

The way to handle this is to use different gaps for the first two tabs vs the settings tab. I have it so that the first two tabs are using 6px gap, and then the Settings tab uses 2px gap:

https://github.com/user-attachments/assets/459fdc26-ce4d-4816-bcad-dfd5b56dbd19

I also tried to reduce the 2px gap between the green ring and the avatar to be just 1px so we save some space there too. cc @Expensify/design for thoughts on all of this

[shawnborton]

Also it looks like the status bubble uses the wrong border color around it, it should match the bg of the tab bar:

[shawnborton]

Also it looks like the RBR dot is floating too high up:

From Figma, we have this:

[shawnborton]

Also, the tabs that are not active should use textSupporting for the color, not our standard text color.

[dannymcclain]

Love all those comments Shawn! Something looks weird with the 1px gap around the selected avatar though... It doesn't look even to me? (Closer on the sides than it is on the top and bottom... No idea why that would be)

[shawnborton]

Oh boy it was set to 33x34... good eye, my b! This is an updated version that looks even:

[rushatgabhane]

@BhuvaneshPatil bump on the above

[BhuvaneshPatil]

@rushatgabhane I modified the code for given margins that is - 6px for inbox and search and 2px for avatar. It looks good when we are on inbox or search page but when we have green ring it pushes the label down (for Settings)

[shawnborton]

It looks good when we are on inbox or search page but when we have green ring it pushes the label down (for Settings)

Is there a way to absolutely position the green ring? That's what We have in Figma I believe.

[BhuvaneshPatil]

Yes, I am thinking of same. We have wrapped avatar with view and used that view's border, that pushes it down. I am experimenting if we can use absolute positioning

[BhuvaneshPatil]

[shawnborton]

Looks like the alignment is still slightly off and incorrect. Can you keep adjusting please? Happy to help provide any direction if needed, just let us know. Going to spin up a test build in the meantime.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48003/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48003/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48003/NewExpensify.dmg	https://48003.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[shawnborton]

Hmm the iOS app crashes when I try to open it from the test build. Any ideas?

[BhuvaneshPatil]

I am able to run the app locally on the same branch.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48003/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48003/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48003/NewExpensify.dmg	https://48003.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[dubielzyk-expensify]

There's some funky jumps happening on the profile photo:

Also, do we want the inactive label text color to be secondary color or primary @shawnborton ?

[shawnborton]

Good catch, we should not see any "jumping" besides the label text becoming bold.

And the inactive labels should use textSupporting color as you mentioned.

[shawnborton]

@BhuvaneshPatil can you try running the test build on iOS from above (if you have an iPhone)? It's still crashing for me.

[BhuvaneshPatil]

The jumpy behaviour is because I am adjusting top margins when we have ring or emoji status,I have done for keeping the text on same line

[shawnborton]

We need to remove the jumpy behavior and make sure everything feels "fixed" in place - can you please adjust?

[BhuvaneshPatil]

@shawnborton I made the border absolute, it will solve the issue for selected avatar, can you please provide design/gap numbers of margin for avatar with emoji status please