App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Some of the report previews don't show the receipt preview

Open m-natarajan opened this issue 1 year ago • 11 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @youssef-lr Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724166388296949

Action Performed:

  1. Go to staging.new.expensify.com
  2. Submit few expenses by scanning receipt

Expected Result:

All the report preview should show the receipt preview

Actual Result:

Some of the report previews don't show the receipt preview, have to open the report then navigate back to see them.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Screenshot 2024-08-20 at 16 06 00

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eef70c2f6c535337
  • Upwork Job ID: 1829179854819733890
  • Last Price Increase: 2024-08-29
Issue OwnerCurrent Issue Owner: @aimane-chnaif

m-natarajan avatar Aug 24 '24 14:08 m-natarajan

Current assignee @youssef-lr is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] avatar Aug 24 '24 14:08 melvin-bot[bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Aug 24 '24 14:08 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Aug 24 '24 14:08 MelvinBot

looking

isabelastisser avatar Aug 26 '24 19:08 isabelastisser

discussion here

isabelastisser avatar Aug 27 '24 16:08 isabelastisser

Job added to Upwork: https://www.upwork.com/jobs/~01eef70c2f6c535337

melvin-bot[bot] avatar Aug 29 '24 15:08 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

melvin-bot[bot] avatar Aug 29 '24 15:08 melvin-bot[bot]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

JKobrynski avatar Sep 03 '24 10:09 JKobrynski

Adding Hot Pick since @youssef-lr is assigned to multiple quality issues

muttmuure avatar Sep 05 '24 17:09 muttmuure

I think I can manage to work on this next week @muttmuure, but if someone would like to volunteer: I posted my thoughts here https://expensify.slack.com/archives/C049HHMV9SM/p1725558647007169?thread_ts=1724166388.296949&cid=C049HHMV9SM

youssef-lr avatar Sep 06 '24 16:09 youssef-lr

@youssef-lr @isabelastisser @JKobrynski @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Sep 07 '24 17:09 melvin-bot[bot]

no updates!

isabelastisser avatar Sep 09 '24 18:09 isabelastisser

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Sep 10 '24 18:09 melvin-bot[bot]

@youssef-lr, any updates? Do you need @muttmuure to reassign it?

isabelastisser avatar Sep 10 '24 19:09 isabelastisser

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Sep 12 '24 18:09 melvin-bot[bot]

Bump @youssef-lr

isabelastisser avatar Sep 13 '24 17:09 isabelastisser

@isabelastisser I'm planning to work on this next week

youssef-lr avatar Sep 13 '24 20:09 youssef-lr

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif 10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] avatar Sep 16 '24 18:09 melvin-bot[bot]

@youssef-lr will work on it this week.

isabelastisser avatar Sep 17 '24 13:09 isabelastisser

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif 12 days overdue now... This issue's end is nigh!

melvin-bot[bot] avatar Sep 18 '24 18:09 melvin-bot[bot]

^

aimane-chnaif avatar Sep 23 '24 07:09 aimane-chnaif

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Sep 26 '24 18:09 melvin-bot[bot]

@youssef-lr, can you please provide an update? Thanks!

isabelastisser avatar Sep 26 '24 20:09 isabelastisser

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Sep 30 '24 18:09 melvin-bot[bot]

I'm currently working on this!

youssef-lr avatar Sep 30 '24 20:09 youssef-lr

Starting a discussion here https://expensify.slack.com/archives/C03TQ48KC/p1727731553397549

youssef-lr avatar Sep 30 '24 21:09 youssef-lr

I'm done with the implementation and I think it turned out great, the new behavior is:

  1. Only transactions that have a "warning" violation are returned via OpenApp
  2. For chats / policy expense chats, the remaining transactions are now fetched during GetOlderActions/GetNewerActions only when the action is a REPORTPREVIEW
  3. For money request reports, we already send back the transactions in OpenReport

Will be working on tests now to make the PRs available for review.

youssef-lr avatar Oct 01 '24 18:10 youssef-lr

Auth ready for review. The App PR was merged by mistake, I branched off of to create another PR, when that PR got merged git merged the other PR as well.

youssef-lr avatar Oct 02 '24 22:10 youssef-lr

Not overdue!

isabelastisser avatar Oct 04 '24 15:10 isabelastisser

@youssef-lr, @isabelastisser, @JKobrynski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 04 '24 18:10 melvin-bot[bot]