[$250] Invoice - Billable option is disabled after sending invoice with billable option enabled

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.22-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Billable option is set to default to billable on Old Dot

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice
3. Enter amount and select a participant
4. Select the workspace with the default billable option
5. Send the invoice with billable option enabled
6. Click on the invoice preview twice to go to invoice report

Expected Result:

Billable option will remain enabled as the invoice is sent with billable option enabled

Actual Result:

Billable option is disabled in the invoice report when the invoice is sent with billable option enabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/2799937a-5567-4188-9636-1d6d5138adc9

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ffc1130b4a222fd
• Upwork Job ID: 1828518698402427125
• Last Price Increase: 2024-09-03

Issue Owner

Current Issue Owner: @c3024

[melvin-bot[bot]]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - Billable option is disabled after sending invoice with billable option enabled

What is the root cause of that problem?

Billable value isn't passed in the parameter object to backend. https://github.com/Expensify/App/blob/c7ec59bb4ff3996c2dfa218c8d7a4d35dc5cebc7/src/libs/actions/IOU.ts#L3596-L3634

What changes do you think we should make in order to solve the problem?

• Pass billable parameter to backend and update the backend if required. billable: transaction?.billable,.
• We should also check for other missing fields.

What alternative solutions did you explore? (Optional)



Result

[melvin-bot[bot]]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~014ffc1130b4a222fd

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

@adelekennedy

This requires changes on backend. So, this should to be Internal.

[Krishna2323]

@c3024, this also requires changes to the frontend, so I guess the frontend part should be fixed externally.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@adelekennedy @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@adelekennedy, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

@c3024 to this point can the frontend work here be done externally?

[c3024]

Yes, the front-end can be handled externally, but backend changes must also be made either first or simultaneously to ensure the front-end changes are implemented correctly.

[adelekennedy]

@cristipaval also hoping you can take a look here!

[melvin-bot[bot]]

@adelekennedy, @c3024 Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

restesting this to see if it's still an issue

[melvin-bot[bot]]

@adelekennedy, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[adelekennedy]

I can't replicate this for some reason - @lanitochka17 is this still reproducible for you?

[melvin-bot[bot]]

@adelekennedy, @c3024 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@adelekennedy, @c3024 Still overdue 6 days?! Let's take care of this!

[melvin-bot[bot]]

@adelekennedy, @c3024 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!