App
App copied to clipboard
[$250] Joined thread stuck in LHN with a :red_circle: and it shows up twice in LHN.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @AndrewGable Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724077993452629
Action Performed:
- Create a room that userA, userB, and userC are in
- Post a comment as userA
- As userB go offline
- Have userC create a thread on userA's comment, while online
- Have userB create a thread on userA's comment, while offline
- Have userB come back online
Expected Result:
Thread displayed one time without any error
Actual Result:
RBR displayed with error and thread displayed twice in LHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Onyx Data:
{
"reportName": "Hey folks! I've reserved a \"Chef's Table\" style dinner for 6 (can maybe expand to as much as 8) at Brochu's Family Tradition Sunday night at 5:30pm! Early dinner because I'm sure we'll all be knackered from our journeys over. Give a ✋ if you're interested in joining!",
"isOptimisticReport": true,
"type": "chat",
"chatType": "policyRoom",
"isOwnPolicyExpenseChat": false,
"isPinned": false,
"lastActorAccountID": 0,
"lastMessageTranslationKey": "",
"lastMessageHtml": "",
"lastReadTime": "2024-08-15 22:13:10.187",
"lastVisibleActionCreated": "2024-08-15 22:13:10.187",
"notificationPreference": "hidden",
"oldPolicyName": "Expensify Chat",
"ownerAccountID": 0,
"parentReportActionID": "1849499882279174199",
"parentReportID": "4569022691530677",
"participants": {
"3064822": {
"hidden": false,
"role": "admin"
},
"3079111": {
"hidden": false,
"role": "member"
}
},
"policyID": "063B20AF6F45E248",
"reportID": "8214043543876468",
"stateNum": 0,
"statusNum": 0,
"description": "",
"avatarUrl": "",
"pendingFields": {
"createChat": "add"
},
"errorFields": {
"createChat": {
"1723759990438375": "Auth OpenReport returned an error"
}
}
}
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ad3492834b7f724d
- Upwork Job ID: 1827073269001925896
- Last Price Increase: 2024-11-29
Current assignee @AndrewGable is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.
Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@mallenexpensify - Can you try to reproduce based on those steps?
Was partially able to reproduce, which I think is the core bug. ie. After coming back online as User B, I see RBR in the thread and in LHN (I don't see it shown as twice in LHN though)
I was thinking of adding External and asking a C+ to attempt reproduction too, whatcha think?
Sounds great!
Job added to Upwork: https://www.upwork.com/jobs/~01ad3492834b7f724d
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)
@brunovjk can you plz attempt reproduction and share you're findings?
Was partially able to reproduce, which I think is the core bug. ie. After coming back online as User B, I see RBR in the thread and in LHN (I don't see it shown as twice in LHN though)
I got the same result:
Can we confirm the expected behavior? Should both messages go to a single thread right? In that case, 'message from B' will go to thread from C. I'll investigate further during the week, and I'm also keeping an eye out for proposals. What do you think @mallenexpensify? Thank you :D
@mallenexpensify Should we bump into slack to look for proposals?
@AndrewGable , can you retest to see if you're experiencing both RBR displayed with error and thread displayed twice in LHN as the actual behaviour? (since @brunovjk and I weren't able to reproduce 'displayed twice').
Then, if needed, we can update the OP for actual and expected.
Curious how easy/tough this bug will be to fix.
Hi @mallenexpensify, @AndrewGable, @brunovjk,
I’m encountering the same behavior as @mallenexpensify mentioned here.
When User-B goes online, they receive the following response. It appears to be an issue on the backend.
OpenReport:
{
"code": 666,
"jsonCode": 666,
"type": "Expensify\\Libs\\Error\\ExpError",
"UUID": "5CBABCBB-13F3-4535-9AB2-28C50BDDD7A2",
"message": "Auth OpenReport returned an error",
"title": "",
"data": {
"onyxData": [
{
"onyxMethod": "merge",
"key": "report_8790068615647771",
"value": {
"errorFields": {
"createChat": {
"1724824587908180": "Auth OpenReport returned an error"
}
}
}
}
]
},
"htmlMessage": "",
"onyxData": [
{
"onyxMethod": "merge",
"key": "report_8790068615647771",
"value": {
"errorFields": {
"createChat": {
"1724824587908180": "Auth OpenReport returned an error"
}
}
}
}
],
"requestID": "8ba20ee95962d1e0-MCT"
}
AddComment:
{
"code": 666,
"jsonCode": 666,
"type": "Expensify\\Libs\\Error\\ExpError",
"UUID": "E490CD6D-46BF-4EE2-8B4F-51672557284A",
"message": "You don't have access to this chat room.",
"title": "Room not accessible",
"data": {
"onyxData": [
{
"onyxMethod": "merge",
"key": "reportActions_8790068615647771",
"value": {
"3613819486451814722": {
"errors": {
"1724824588672995": "You don't have access to this chat room."
}
}
}
}
]
},
"htmlMessage": "",
"onyxData": [
{
"onyxMethod": "merge",
"key": "reportActions_8790068615647771",
"value": {
"3613819486451814722": {
"errors": {
"1724824588672995": "You don't have access to this chat room."
}
}
}
}
],
"requestID": "8ba20eee1bb9de43-MCT"
}
I investigated, and it does seem to be a response issue. I’ll trigger an internal to review the backend codes for us. 😊
🎀👀🎀 C+ reviewed
Current assignee @AndrewGable is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
Sorry for the unnecessary tagging above, @AndrewGable. I wasn’t sure if you could assist with the backend codebase.
Yes I can, what am I looking for?
@AndrewGable take a look at this https://github.com/Expensify/App/issues/47708#issuecomment-2315068847 please :D thank you.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@AndrewGable, @mallenexpensify, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!
Hey @AndrewGable :D did you make any changes to the backend? I just tested it (v9.0.28-0) and it seems like everything works fine now, I can no longer reproduce the issue:
reproduce_47708_web
https://github.com/user-attachments/assets/40f0ba60-3fbc-472f-9683-3b3cb323fcbd
What about you @mallenexpensify? Thank you.
@AndrewGable @mallenexpensify @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Unable to reproduce but only cuz, when I get to
Have userB create a thread on userA's comment, while offline
When I click to thread the comment, I just get the loading screen.
Throwing retest-weekly on this and bumping to weekly
Removing from project since it's not a UX reliability issue anymore
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@AndrewGable @mallenexpensify @brunovjk this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
Waiting for retest
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Waiting for retest