App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Joined thread stuck in LHN with a :red_circle: and it shows up twice in LHN.

Open m-natarajan opened this issue 1 year ago • 76 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @AndrewGable Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724077993452629

Action Performed:

  1. Create a room that userA, userB, and userC are in
  2. Post a comment as userA
  3. As userB go offline
  4. Have userC create a thread on userA's comment, while online
  5. Have userB create a thread on userA's comment, while offline
  6. Have userB come back online

Expected Result:

Thread displayed one time without any error

Actual Result:

RBR displayed with error and thread displayed twice in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Google Chrome 2024-08-19 at 10 32 13 Google Chrome 2024-08-19 at 10 32 29

Onyx Data:

{
    "reportName": "Hey folks! I've reserved a \"Chef's Table\" style dinner for 6 (can maybe expand to as much as 8) at Brochu's Family Tradition Sunday night at 5:30pm! Early dinner because I'm sure we'll all be knackered from our journeys over. Give a ✋ if you're interested in joining!",
    "isOptimisticReport": true,
    "type": "chat",
    "chatType": "policyRoom",
    "isOwnPolicyExpenseChat": false,
    "isPinned": false,
    "lastActorAccountID": 0,
    "lastMessageTranslationKey": "",
    "lastMessageHtml": "",
    "lastReadTime": "2024-08-15 22:13:10.187",
    "lastVisibleActionCreated": "2024-08-15 22:13:10.187",
    "notificationPreference": "hidden",
    "oldPolicyName": "Expensify Chat",
    "ownerAccountID": 0,
    "parentReportActionID": "1849499882279174199",
    "parentReportID": "4569022691530677",
    "participants": {
        "3064822": {
            "hidden": false,
            "role": "admin"
        },
        "3079111": {
            "hidden": false,
            "role": "member"
        }
    },
    "policyID": "063B20AF6F45E248",
    "reportID": "8214043543876468",
    "stateNum": 0,
    "statusNum": 0,
    "description": "",
    "avatarUrl": "",
    "pendingFields": {
        "createChat": "add"
    },
    "errorFields": {
        "createChat": {
            "1723759990438375": "Auth OpenReport returned an error"
        }
    }
}

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad3492834b7f724d
  • Upwork Job ID: 1827073269001925896
  • Last Price Increase: 2024-11-29

m-natarajan avatar Aug 20 '24 12:08 m-natarajan

Current assignee @AndrewGable is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

melvin-bot[bot] avatar Aug 20 '24 12:08 melvin-bot[bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Aug 20 '24 12:08 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Aug 20 '24 12:08 MelvinBot

@mallenexpensify - Can you try to reproduce based on those steps?

AndrewGable avatar Aug 20 '24 14:08 AndrewGable

Was partially able to reproduce, which I think is the core bug. ie. After coming back online as User B, I see RBR in the thread and in LHN (I don't see it shown as twice in LHN though)

I was thinking of adding External and asking a C+ to attempt reproduction too, whatcha think?

image

mallenexpensify avatar Aug 21 '24 00:08 mallenexpensify

Sounds great!

AndrewGable avatar Aug 21 '24 00:08 AndrewGable

Job added to Upwork: https://www.upwork.com/jobs/~01ad3492834b7f724d

melvin-bot[bot] avatar Aug 23 '24 19:08 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

melvin-bot[bot] avatar Aug 23 '24 19:08 melvin-bot[bot]

@brunovjk can you plz attempt reproduction and share you're findings?

mallenexpensify avatar Aug 23 '24 20:08 mallenexpensify

Was partially able to reproduce, which I think is the core bug. ie. After coming back online as User B, I see RBR in the thread and in LHN (I don't see it shown as twice in LHN though)

I got the same result: Screenshot 2024-08-24 at 09 09 33

Can we confirm the expected behavior? Should both messages go to a single thread right? In that case, 'message from B' will go to thread from C. I'll investigate further during the week, and I'm also keeping an eye out for proposals. What do you think @mallenexpensify? Thank you :D

brunovjk avatar Aug 24 '24 12:08 brunovjk

@mallenexpensify Should we bump into slack to look for proposals?

brunovjk avatar Aug 27 '24 14:08 brunovjk

@AndrewGable , can you retest to see if you're experiencing both RBR displayed with error and thread displayed twice in LHN as the actual behaviour? (since @brunovjk and I weren't able to reproduce 'displayed twice').

Then, if needed, we can update the OP for actual and expected.

Curious how easy/tough this bug will be to fix.

mallenexpensify avatar Aug 27 '24 23:08 mallenexpensify

Hi @mallenexpensify, @AndrewGable, @brunovjk,

I’m encountering the same behavior as @mallenexpensify mentioned here.

When User-B goes online, they receive the following response. It appears to be an issue on the backend.

OpenReport:

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "5CBABCBB-13F3-4535-9AB2-28C50BDDD7A2",
    "message": "Auth OpenReport returned an error",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "report_8790068615647771",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1724824587908180": "Auth OpenReport returned an error"
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "report_8790068615647771",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1724824587908180": "Auth OpenReport returned an error"
                    }
                }
            }
        }
    ],
    "requestID": "8ba20ee95962d1e0-MCT"
}

AddComment:

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "E490CD6D-46BF-4EE2-8B4F-51672557284A",
    "message": "You don't have access to this chat room.",
    "title": "Room not accessible",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "reportActions_8790068615647771",
                "value": {
                    "3613819486451814722": {
                        "errors": {
                            "1724824588672995": "You don't have access to this chat room."
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reportActions_8790068615647771",
            "value": {
                "3613819486451814722": {
                    "errors": {
                        "1724824588672995": "You don't have access to this chat room."
                    }
                }
            }
        }
    ],
    "requestID": "8ba20eee1bb9de43-MCT"
}

ijmalik avatar Aug 28 '24 11:08 ijmalik

I investigated, and it does seem to be a response issue. I’ll trigger an internal to review the backend codes for us. 😊

🎀👀🎀 C+ reviewed

brunovjk avatar Aug 28 '24 20:08 brunovjk

Current assignee @AndrewGable is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] avatar Aug 28 '24 20:08 melvin-bot[bot]

Sorry for the unnecessary tagging above, @AndrewGable. I wasn’t sure if you could assist with the backend codebase.

brunovjk avatar Aug 28 '24 20:08 brunovjk

Yes I can, what am I looking for?

AndrewGable avatar Aug 29 '24 21:08 AndrewGable

@AndrewGable take a look at this https://github.com/Expensify/App/issues/47708#issuecomment-2315068847 please :D thank you.

brunovjk avatar Aug 29 '24 22:08 brunovjk

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Aug 30 '24 16:08 melvin-bot[bot]

@AndrewGable, @mallenexpensify, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Sep 02 '24 18:09 melvin-bot[bot]

Hey @AndrewGable :D did you make any changes to the backend? I just tested it (v9.0.28-0) and it seems like everything works fine now, I can no longer reproduce the issue:

reproduce_47708_web

https://github.com/user-attachments/assets/40f0ba60-3fbc-472f-9683-3b3cb323fcbd

What about you @mallenexpensify? Thank you.

brunovjk avatar Sep 03 '24 14:09 brunovjk

@AndrewGable @mallenexpensify @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Sep 03 '24 18:09 melvin-bot[bot]

Unable to reproduce but only cuz, when I get to

Have userB create a thread on userA's comment, while offline

When I click to thread the comment, I just get the loading screen. image

Throwing retest-weekly on this and bumping to weekly

mallenexpensify avatar Sep 04 '24 22:09 mallenexpensify

Removing from project since it's not a UX reliability issue anymore

muttmuure avatar Sep 05 '24 17:09 muttmuure

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Sep 06 '24 16:09 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Sep 13 '24 16:09 melvin-bot[bot]

@AndrewGable @mallenexpensify @brunovjk this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Sep 17 '24 18:09 melvin-bot[bot]

Waiting for retest

mallenexpensify avatar Sep 17 '24 21:09 mallenexpensify

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Sep 20 '24 16:09 melvin-bot[bot]

Waiting for retest

brunovjk avatar Sep 22 '24 15:09 brunovjk