App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Approve button not disappear after approving report offline if advanced approval set

Open izarutskaya opened this issue 6 months ago • 28 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.19.2 Reproducible in staging?: Y Reproducible in production?: N Found when validating PR : https://github.com/Expensify/App/pull/44940 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition: create a control workspace, set "Manually approve all expenses" over to $10 and set advanced approval in OD:

  • boss owner (admin) submits to mini owner
  • mini owner (admin) submits boss owner
  • manager (employee) submits to mini owner forwards to mini owner over limit forwards (limit 100) to boss owner
  • employee 1 (employee) submits to manager
  • employee 2(employee) submits to manager
  1. Log in as an employee 1 and submit an expense below $100, e.g. $25
  2. Log in as an manager
  3. Disable internet connection
  4. Approve the report

Expected Result:

The approve button dsiappears

Actual Result:

The approve button is still displayed until user returns online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/5b3f27ae-2414-42d4-9b3b-e62419645ce4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01682c8c3ddb795078
  • Upwork Job ID: 1829413690213012581
  • Last Price Increase: 2024-09-06
Issue OwnerCurrent Issue Owner: @

izarutskaya avatar Aug 12 '24 20:08 izarutskaya