Update Payment flow on clicking `Pay`

[madmax330]

Part of the <Project Name> project

Main issue: https://github.com/Expensify/Expensify/issues/382977 Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.u0rlixqcmug6 Project: https://github.com/orgs/Expensify/projects/114

Feature Description

Relevant doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.jxlg73mn39np

Manual Test Steps

Create an invoice, as the receiver click on pay and make sure the different dialogs work correctly.

Automated Tests

Issue Owner

Current Issue Owner: @rezkiy37

[madmax330]

We might want to split this one up into different PRs for each of the different payment methods

[danielrvidal]

@madmax330 any updates on this one? We'll probably have to make some progress to hit SuiteWorld, not sure if it's been tracked somewhere else.

[madmax330]

Going to work on it this week, I think it's holding on some backend changes

[madmax330]

Changing to weekly so I can get this done

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

Actively working on the issue.

[madmax330]

Not overdue

[madmax330]

Still working on the Auth part

[rezkiy37]

I am OOO till Tuesday and will continue to work on this issue later.

[rezkiy37]

Waiting for the backend.

[rezkiy37]

Waiting for the backend.

[rezkiy37]

No updates. We are waiting on the backend.

[cristipaval]

backend changes are still WIP.

[cristipaval]

The backend PR is ready for review.

[rezkiy37]

Has it not been deployed to the staging server yet? If not, should it be there after the merge?

[cristipaval]

I'll keep you posted when the backend PR hits staging

[cristipaval]

@rezkiy37, the backend changes are in staging.

[rezkiy37]

I always get the 403 error. Was the API updated?

Screenshots

cc @cristipaval

[cristipaval]

@rezkiy37 , the payment type has to be "Expensify", not ACH

[rezkiy37]

@cristipaval, it throws "404 Stripe customerID does not exist".

Screenshots

[cristipaval]

@rezkiy37 What bank account did you use, and how did you set it up on your account?

[rezkiy37]

@cristipaval I've used those 2 bank accounts I added quite a long time ago. As I remember I added them in the sandbox mode. So probably they are not real.

Screenshots

Do you know how I can test the payment?

[cristipaval]

Could you please try adding a new bank account? Or maybe delete the current one you have and re-add it.

[rezkiy37]

Testing it.

[rezkiy37]

I've added a new bank account for a new user. However, I still have the error. Important: I can only use sandbox bank accounts, not real ones. So I am on the staging server with the mock accounts. I think we are good to continue with the PR Since we verified the payload the app sends. Let's open the PR and ask QA to test it with the real bank accounts. @cristipaval WDYT?

Screenshots

[cristipaval]

I've added a new bank account for a new user. However, I still have the error. Important: I can only use sandbox bank accounts, not real ones. So I am on the staging server with the mock accounts. I think we are good to continue with the PR Since we verified the payload the app sends. Let's open the PR and ask QA to test it with the real bank accounts. @cristipaval WDYT?

Screenshots

I setup my local environment to test payments with Expensify. I'll test your PR today and let you know.

[rezkiy37]

Hi! I am writing to let you know about my upcoming vacation until the 7th Tuesday of January. I will resume my work on the issue when I get back.

Wishing you a Happy New Year!

[cristipaval]

Just had a chat with @madmax330 and we chatted about the error that is thrown from the backend.

[cristipaval]

Posting here for me whenever I have time to work again on this:

• We currently throw here when the payer has no Stripe customer ID
• We need to check in peek() whether the payer has that ID and create it when they don't, using the Stripe::createCustomer function from Stripe.cpp.

[cristipaval]

Calm down, Melv