Expensify
Track- Error appears when Submit expense to someone
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.5-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4704990&group_by=cases:section_id&group_order=asc&group_id=309130 Email or phone of affected tester (no customers): [email protected]
Action Performed:
- Login with new account
- Go to Self DM> Track expense
- Submit the expense to someone
- Wait for a minute
Expected Result:
There should be no errors and submitted expense should be present on LHN and report
Actual Result:
Red dot and error appears after Submit expense to someone
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/e719bca2-468b-491e-a7e0-3b5721e2c76f
Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Job added to Upwork: https://www.upwork.com/jobs/~01408041e16e8fde12
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)
@alexpensify @Pujan92 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.
@alexpensify, @Pujan92 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@pasyukevich any update on when the PR will be ready for review? Thanks!
I was able to reproduce the issue on Android. I am looking for the root cause and don't have an ETA yet for the PR.
Do you also mean that here we do not need to have the proposal step and I need to create the PR?
@alexpensify Hi. Is the issue still open to proposal? If it is, I would like to investigate this issue.
@pasyukevich - No, you would create the PR only.
@jacobkim9881 this one is not open right now. Thanks for your interest.
@alexpensify @Pujan92 @pasyukevich this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@thienlnam any context on why we add this "changed the expense" system message in this flow? 🤔
We add a MODIFIEDEXPENSE reportAction when the tracked expense is submitted to someone for historical context. However, I'm not sure that message is ideal for this scenario. I think we just need to change the copy here maybe to something like 'submitted tracked expense'?
Why did we decide to add aMODIFIEDEXPENSE reportAction for historical context of an expense being submitted not modified? 🤔
I think we just need to change the copy here maybe to something like 'submitted tracked expense'?
Even this doesn't seem necessary. If I go to Submit expense > Jack, we don't add the "submitted $x" reportAction in the iouReport. So why do we need to do that here? The only time we use that reportAction is when a workspace has delayed submission enabled and the expense report is actually submitted (be that manually, or via harvesting).
iouReports are the equivalent of instant submit, where the concept of having to submit a report doesn't exist. So I think we remove this reportAction altogether.
This was a tracked expense, and then when it was submitted it became a reimbursable expense which is why it has a modified reportAction. I feel like there needs to be some indication that something happened to this tracked expense
But they don't know one way or the other right? Like a tracked expense is basically secretly non-reimbursable.
I don't think it matters to the person that is getting the expense submitted to them, but for the person that created the tracked expense it might be nice to see that this tracked expense has been updated and is now being submitted to someone.
Though I don't feel that strongly so if you want we can remove the reportAction that gets added when the expense is moved