Expensify
[Search v1] - Action field remains as "Paid" after expenses are unapproved until page is revisited
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.5-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat as admin
- Submit two expenses
- Go to Search > Shared
- Click on the grouped expenses
- Pay elsewhere the expense
- Go back to Search > Shared
- Click on the grouped expenses
- Click on the report header
- Click Unapprove
Expected Result:
The action field for the grouped expenses will turn to "Action"
Actual Result:
The action field for the grouped expenses remains "Paid", until the Search page is revisited
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/e7e4f5c9-c7af-4fa9-8fc5-6990d12ebb44
Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
hmm this is a tricky one. We save the action in its own key in snapshot_ so the live updates don't change this key since the live onyx data, e.g. report_ and transactions_ don't have the action key.
This is not a blocker though since I was able to reproduce in production.
@tylerkaraszewski Whoops! This issue is 2 days overdue. Let's get this updated quick!
@tylerkaraszewski Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
@luacmartins - do you think we can make this external, or are you interested in working on it?
I can't reproduce this exact issue anymore since I don't see an option to Unapprove. I can reproduce with the Cancel payment option.
This happens because we update the report's statusNum in Onyx and computing the new state when cancelling the payment, but the Search page uses the action key computed on the server to determine what the next action should be. I'm not really sure how to solve since it'd require a fundamental change to the Search design.
8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!