App icon indicating copy to clipboard operation
App copied to clipboard

mWeb-Tag-When dependent tags are being disabled, "tag no longer valid" message is not shown

Open lanitochka17 opened this issue 1 year ago • 14 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4694802 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/hom
  2. Login as employee
  3. Open Workspace chat
  4. Create an expense selecting category and dependent tags
  5. Now in other device open admin account
  6. Disable the category and all dependent tags option
  7. Now as employee, open the expense

Expected Result:

When dependent tags are being disabled, "tag no longer valid" message must be shown

Actual Result:

For category after disabled "category no longer valid" message shown but for dependent tags no message displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [x] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/83b5deca-ffb8-48de-b6a5-6f5705dcf6b6

https://github.com/Expensify/App/assets/78819774/84e97238-14f0-4a6d-b227-2e7f7a74f711

View all open jobs on GitHub

lanitochka17 avatar Jul 05 '24 14:07 lanitochka17

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jul 05 '24 14:07 melvin-bot[bot]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Jul 05 '24 14:07 lanitochka17

We think that this bug might be related to #wave-collect - Release 1

lanitochka17 avatar Jul 05 '24 14:07 lanitochka17

Require BE fix There are no violations on the API response for multilevel tags & dependant tags if it is disabled

nyomanjyotisa avatar Jul 06 '24 10:07 nyomanjyotisa

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 08 '24 18:07 melvin-bot[bot]

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Jul 10 '24 18:07 melvin-bot[bot]

@twisterdotcom 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Jul 12 '24 18:07 melvin-bot[bot]

Okay, making Internal

twisterdotcom avatar Jul 15 '24 15:07 twisterdotcom

@twisterdotcom this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jul 19 '24 18:07 melvin-bot[bot]

No volunteers yet. Not really a hot pick for now.

twisterdotcom avatar Jul 24 '24 14:07 twisterdotcom

Asking for some help in wave-control: https://expensify.slack.com/archives/C06ML6X0W9L/p1722599730089979

twisterdotcom avatar Aug 02 '24 11:08 twisterdotcom

Going to try to consolidate my dependent tag issues and find a single assignee

twisterdotcom avatar Aug 13 '24 17:08 twisterdotcom

Will look at this as a part of the tags project soon.

yuwenmemon avatar Aug 28 '24 23:08 yuwenmemon

Same as above.

twisterdotcom avatar Sep 07 '24 08:09 twisterdotcom

I think this actually might just be solved with the violations project, right @twisterdotcom?

yuwenmemon avatar Sep 18 '24 05:09 yuwenmemon

Possible. Do we have a PR to link to?

twisterdotcom avatar Sep 18 '24 09:09 twisterdotcom

No I was just thinking about it in the abstract 😂

The violations project isn't complete yet either. But a man can dream...

yuwenmemon avatar Sep 18 '24 17:09 yuwenmemon

Shall we just close this?

twisterdotcom avatar Sep 26 '24 23:09 twisterdotcom

Yeah

yuwenmemon avatar Oct 01 '24 18:10 yuwenmemon