App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [One expense report] Approving a report, followed by automations, causes a one-expense report to go blank or loading skeleton

Open m-natarajan opened this issue 1 year ago • 12 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.4-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720018295381949

Action Performed:

  1. Set up a Collect policy on NewDot as userA
  2. On OldDot, configure a bank account, keep the auto-reimburse limit at $100
  3. On OldDot, set the manual approve amount to $0 (so all reports need approval)
  4. On OldDot, invite userB who submits expenses
  5. On NewDot, have userB submit a $50 expense to the right policy
  6. On NewDot, have userA approve the report

Expected Result:

The one expense report shows the green paid checkmarks and is otherwise unchanged

Actual Result:

The one expense report goes blank, Loading skeleton and clicking the expense displayed Hmm, it's not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [X] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

CleanShot 2024-07-03 at 09 36 32

https://github.com/Expensify/App/assets/38435837/b0a2dc26-1d35-497f-a39f-8369cb9f997e

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01328ea73a58f5c7eb
  • Upwork Job ID: 1810441796510837868
  • Last Price Increase: 2024-07-08
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

m-natarajan avatar Jul 04 '24 23:07 m-natarajan

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jul 04 '24 23:07 melvin-bot[bot]

Still trying to repro

jliexpensify avatar Jul 05 '24 10:07 jliexpensify

@jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jul 08 '24 18:07 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~01328ea73a58f5c7eb

melvin-bot[bot] avatar Jul 08 '24 22:07 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

melvin-bot[bot] avatar Jul 08 '24 22:07 melvin-bot[bot]

Hi @ZhenjaHorbach I was having some issues reproducing last week but we're going to open this one up to Contributors. Hopefully you can repro this!

jliexpensify avatar Jul 08 '24 22:07 jliexpensify

Hi @ZhenjaHorbach I was having some issues reproducing last week but we're going to open this one up to Contributors. Hopefully you can repro this!

I'll check today or tomorrow if the issue is reproducible or not for me

ZhenjaHorbach avatar Jul 09 '24 07:07 ZhenjaHorbach

Hmmm Just spent one hour But today I couldn't reproduce it I'll try again tomorrow

But I hope that the contributors will be able to do it So I'm still waiting for proposals anyway

ZhenjaHorbach avatar Jul 10 '24 15:07 ZhenjaHorbach

@ZhenjaHorbach did you get setup and everything and it was working as expected?

trjExpensify avatar Jul 11 '24 18:07 trjExpensify

@ZhenjaHorbach did you get setup and everything and it was working as expected?

@trjExpensify Yes But now I have created new accounts and am trying to reproduce with them Still no success

ZhenjaHorbach avatar Jul 11 '24 19:07 ZhenjaHorbach

Gotcha. Do you have a vid?

trjExpensify avatar Jul 11 '24 20:07 trjExpensify

While I was making the video I broke something 😅 But this is still not this issue

I created many workspaces and attempted to reproduce it with the first report Also I used Pay with Expensify instead Pay elsewhere But the result is the same

https://github.com/Expensify/App/assets/68128028/9eb680e0-579f-47bb-abcc-d367711c7476

ZhenjaHorbach avatar Jul 11 '24 20:07 ZhenjaHorbach

I'll attempt to reproduce it today If I'm unsuccessful, I'll seek assistance from the C+ team Maybe someone else will have better luck

ZhenjaHorbach avatar Jul 11 '24 20:07 ZhenjaHorbach

Yeah cool, because when you click approve it should be paid automatically if you have auto-reimbursement enabled. You shouldn't be needing to click pay at all.

trjExpensify avatar Jul 11 '24 23:07 trjExpensify

Yeah cool, because when you click approve it should be paid automatically if you have auto-reimbursement enabled. You shouldn't be needing to click pay at all.

Oh, Yeah You are right, thank you for your comment

But anyway everything works well

https://github.com/user-attachments/assets/2fe15148-3ff4-4a40-a1ea-6810348da41d

ZhenjaHorbach avatar Jul 12 '24 07:07 ZhenjaHorbach

I notice when trying to reproduce if I open the report from the search tab the new messages action not displayed (approve and paid message, also if I send message it not displayed), and I need to refresh the browser or open it from user report in workspace. And this not match the attached video in issue description. Maybe if the new message action appear, we can reproduce the issue.

ahmedGaber93 avatar Jul 12 '24 08:07 ahmedGaber93

I notice when trying to reproduce if I open the report from the search tab the new messages action not displayed (approve and paid message, also if I send message it not displayed), and I need to refresh the browser or open it from user report in workspace. And this not match the attached video in issue description. Maybe if the new message action appear, we can reproduce the issue.

I've never had problems with search The only thing I noticed If I create a workspace in OD, it does not appear in ND and I need to refresh the page (For the same account) But in search all reports are displayed normally

ZhenjaHorbach avatar Jul 12 '24 08:07 ZhenjaHorbach

I mean your video here https://github.com/Expensify/App/issues/44878#issuecomment-2225035734 after clicking "Approve" the approved and paid message not appear util refreshing the browser

ahmedGaber93 avatar Jul 12 '24 08:07 ahmedGaber93

I mean your video here #44878 (comment) after clicking "Approve" the approved and paid message not appear util refreshing the browser

Now I got it 😅 Thank you Maybe you are right This looks like a new issue since QA doesn’t have this problem in the example video It might be worth checking the history of recent changes

ZhenjaHorbach avatar Jul 12 '24 08:07 ZhenjaHorbach

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jul 15 '24 16:07 melvin-bot[bot]

@jliexpensify, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 15 '24 18:07 melvin-bot[bot]

Not overdue, any updates @ZhenjaHorbach?

jliexpensify avatar Jul 16 '24 04:07 jliexpensify

About an issue when we don’t see approved and paid with Expensify messages after pressing Approve button Looks like the issue came from this PR And problem related with PaginationUtils.getContinuousChain after which we remove new report actions after approval

But I'm not sure if this issue is related to our issue Plus I made some changes with PaginationUtils.getContinuousChain

And I still can't reproduce our issue

https://github.com/user-attachments/assets/13358cbf-3d54-4add-9c8f-11b39e395706

ZhenjaHorbach avatar Jul 16 '24 08:07 ZhenjaHorbach

@jliexpensify @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jul 18 '24 18:07 melvin-bot[bot]

Not overdue I'll try to reproduce the issue again today or tomorrow Otherwise I think we need to find steps to reproduce it

ZhenjaHorbach avatar Jul 18 '24 18:07 ZhenjaHorbach

Just curious - @JmillsExpensify are you still experiencing this issue? Are there any repro steps we're missing?

jliexpensify avatar Jul 18 '24 23:07 jliexpensify

Still can't reproduce

ZhenjaHorbach avatar Jul 22 '24 07:07 ZhenjaHorbach

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jul 22 '24 16:07 melvin-bot[bot]

@JmillsExpensify isn't seeing this anymore, closing.

trjExpensify avatar Jul 22 '24 16:07 trjExpensify