Expensify
[$250] mWeb splash screen displays the iconmark logo at a very small size
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.3-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719557303345799
Action Performed:
- Go to staging.new.expensify.com and refresh the page
- Login and refresh the page
Expected Result:
Splash screen icon mark logo should be same across all platform
Actual Result:
mWeb splash screen displays the iconmark logo at a very small size when compared with native app
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [x] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01a88bc54afc480cd3
- Upwork Job ID: 1807909799628982429
- Last Price Increase: 2024-07-01
Issue Owner
Current Issue Owner: @grgia
Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb splash screen displays the iconmark logo at a very small size.
What is the root cause of that problem?
Size is set to 52x52 for devices with width 479 px and less.
https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L91-L96
What changes do you think we should make in order to solve the problem?
We can update the width and height to some value decided by the design team.
@media screen and (max-width: 479px) {
.splash-logo > svg {
width: 80px;
height: 80px;
}
}
Else, we can also use the same size on all devices.
Then, we'll not need the max-width or min-width conditional items.
I kind of think the best solution is to just get rid of any mobile-only styles here and just use the same thing we use on desktop.
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb splash screen displays the iconmark logo at a very small size
What is the root cause of that problem?
We have different svg sizes defined for small screens here
https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L91-L96
What changes do you think we should make in order to solve the problem?
We should have the same logo size for all devices, we will:
Remove the width limit for the desktop size svg style here: https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L84-L89
Remove the mobile size svg style here: https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L91
@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!
Job added to Upwork: https://www.upwork.com/jobs/~01a88bc54afc480cd3
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb splash screen displays the iconmark logo at a very small size
What is the root cause of that problem?
The iconmark logo appears very small because the width (52px) and height (52px) values set in the media query for screens with a max-width of 479px. https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L91-L96
What changes do you think we should make in order to solve the problem?
The iconmark logo should resize with each screen to avoid the iconmark logo being too big or too small.
// App/blob/main/web/index.html#L90
+.splash-logo {
+ position: absolute;
+ left: 50%;
+ top: 50%;
+ transform: translate(-50%, -50%);
+ text-align: center;
+}
// App/blob/main/web/index.html#L91
@media screen and (max-width: 479px) {
.splash-logo > svg {
- width: 52px;
+ width: 50%;
- height: 52px;
+ height: 50%;
+ max-width: 208px;
}
}
POC
https://github.com/Expensify/App/assets/20178761/aeeafa5c-afca-4841-8e7d-e2942d488de6
What alternative solutions did you explore? (Optional)
Proposal
Please re-state the problem that we are trying to solve in this issue.
splash screen displays the iconmark logo at a very small size
What is the root cause of that problem?
These two styles change the size of the icon based on screen size. The icon's size should be constant for any screen size.
https://github.com/Expensify/App/blob/937c4186409725b57fdaae6ae8e1d8c85a9d52a0/web/index.html#L84-L96
What changes do you think we should make in order to solve the problem?
These two styles should be removed and replaced with one style that covers all screen sizes. This change will address this bug and ensure a consistent UX going forward.
Remove lines 84-96 and replace it with:
//App/web/index.html#L84
.splash-logo > svg {
width: 104px;
height: 104px;
}
📣 @Mmore35! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~01a38afc4ef2929c42
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@ahmedGaber93 Why did you choose a proposal with hard-coded width and height? It's not good because it doesn't resize well on small devices.
I don't think we need to make it resizable based on screen dimensions like what we do in medium and large screen on web, the icon size is fixed, and the green background fit the screen
While a fixed solution might be okay, I believe a responsive icon mark logo will improve the user experience, making it feel more like a native platform.
I really don't think we need multiple sizes for this. I think the size we already use on desktop/web will look great on mobile, and this way we don't need to maintain multiple sizes across devices.
📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@ShridharGoel @grgia @ahmedGaber93 @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.9-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/45405
If no regressions arise, payment will be issued on 2024-07-26. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @ShridharGoel requires payment automatic offer (Contributor)
- @ahmedGaber93 requires payment automatic offer (Reviewer)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
- [ ] [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [ ] [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [ ] [@ahmedGaber93] Determine if we should create a regression test for this bug.
- [ ] [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
payment due next week - @ahmedGaber93 will you fill out the checklist when you have a moment?