App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD #43998] Wrong bottom navigation icon is highlighted

Open m-natarajan opened this issue 1 year ago • 10 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.2-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @allgandalf Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719437029378469

Action Performed:

  1. Open app
  2. Go to search tab
  3. Click on any existing report
  4. Click on the subtitle
  5. Press back button
  6. Press back button again

Expected Result:

User should be on the search page

Actual Result:

the user is on the Chat page, but in bottom navigation, search tab is highlighted

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/86741512-a789-456f-a2b0-eea68fc2f080

https://github.com/Expensify/App/assets/38435837/57b5776f-7369-481c-861f-c6796f4abdc7

View all open jobs on GitHub

m-natarajan avatar Jun 27 '24 00:06 m-natarajan

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 27 '24 00:06 melvin-bot[bot]

[!NOTE] @puneetlath , can i be the C+ here, as i reported this issue and have some context of the same

allgandalf avatar Jun 27 '24 06:06 allgandalf

@WojtekBoman @adamgrzybowski this seems to be another task good for you

mountiny avatar Jun 27 '24 08:06 mountiny

@mountiny I have pending PR for this bug. But it seems to have some problems after merging the newest main. I will investigate it after other high priority issues

adamgrzybowski avatar Jun 27 '24 11:06 adamgrzybowski

Chill melvin, this is been worked on!

allgandalf avatar Jul 01 '24 14:07 allgandalf

@adamgrzybowski how's it going?

puneetlath avatar Jul 03 '24 19:07 puneetlath

@puneetlath old issues were resolved but the reviewer found one more problem. I will investigate it.

adamgrzybowski avatar Jul 04 '24 10:07 adamgrzybowski

any update here @adamgrzybowski ?

allgandalf avatar Jul 08 '24 14:07 allgandalf

@allgandalf from what I understand this issue is a duplicate of this issue: https://github.com/Expensify/App/pull/43998 and the 2nd one is being actively fixed

Kicu avatar Jul 09 '24 09:07 Kicu

that is a good thing, if so then lets put this on hold and retest once that PR gets to production @puneetlath

allgandalf avatar Jul 09 '24 09:07 allgandalf

Still on hold....

allgandalf avatar Jul 12 '24 09:07 allgandalf

still on hold.....

allgandalf avatar Jul 15 '24 11:07 allgandalf

@allgandalf 43998 is on staging now. I'm going to ask for a re-test.

puneetlath avatar Jul 15 '24 12:07 puneetlath

Not reproduced.

https://github.com/user-attachments/assets/c8bc39f3-0d42-4890-abf0-af24bdf7c83d

kavimuru avatar Jul 15 '24 20:07 kavimuru

Great, thanks everyone!

puneetlath avatar Jul 15 '24 20:07 puneetlath