App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-07-17] [$250] [HOLD 36648] Wallet - Idology questions flow does not start after entering bank account details

Open lanitochka17 opened this issue 1 year ago • 22 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4673461 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. Open app or go to staging.new.expensify.com
  2. Log in with any account without a wallet configured
  3. Go to Settings > Wallet
  4. Click on 'Enable wallet'
  5. Follow the bank account flow until the final 'Confirm' page (using Bank: Chase / Account: 1111 / First name: Alberta / Last name: Bobbeth / SSN: 3333)
  6. Tap 'Confirm' button

Expected Result:

Idology questions flow has started

Actual Result:

Nothing happens after pressing the 'Confirm' button. Idology questions flow does not start

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e6b6fcfb-8732-44e1-8f79-1a2251d4896b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014deaa2c3f332d2e4
  • Upwork Job ID: 1806785838003619663
  • Last Price Increase: 2024-06-28
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @OfstadC
Issue OwnerCurrent Issue Owner: @OfstadC

lanitochka17 avatar Jun 26 '24 14:06 lanitochka17

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Jun 26 '24 14:06 melvin-bot[bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 26 '24 14:06 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Jun 26 '24 14:06 github-actions[bot]

We think that this bug might be related to #vip-vsp

lanitochka17 avatar Jun 26 '24 14:06 lanitochka17

@thienlnam @OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Jun 26 '24 14:06 lanitochka17

It seems like this failed because of a non-matching SSN (logs)

I wonder if this was updated for our test bank account recently but it doesn't seem to be from any recent changes

thienlnam avatar Jun 26 '24 15:06 thienlnam

Posted here, https://expensify.slack.com/archives/C03SSAQ7P/p1719415968231039 but don't think this is a result of changes made

thienlnam avatar Jun 26 '24 15:06 thienlnam

Actually, after some confirmation in the thread there's a bug here and it seems to be that the KBA questions do not show up after the initial failure and resubmission

thienlnam avatar Jun 27 '24 14:06 thienlnam

Current assignee @thienlnam is eligible for the DeployBlockerCash assigner, not assigning anyone new.

melvin-bot[bot] avatar Jun 27 '24 14:06 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Jun 27 '24 14:06 github-actions[bot]

PR ready for review: https://github.com/Expensify/App/pull/44628

koko57 avatar Jun 28 '24 16:06 koko57

Job added to Upwork: https://www.upwork.com/jobs/~014deaa2c3f332d2e4

melvin-bot[bot] avatar Jun 28 '24 20:06 melvin-bot[bot]

Current assignee @Pujan92 is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Jun 28 '24 20:06 melvin-bot[bot]

@Pujan92 Any update here?

OfstadC avatar Jul 02 '24 21:07 OfstadC

@Pujan92 Please provide an update by EOD. Thanks!

OfstadC avatar Jul 09 '24 15:07 OfstadC

Sorry @OfstadC, The PR merged and the code in the production on 5th July. I think bcoz of Hold the automation isn't worked for this issue.

Pujan92 avatar Jul 09 '24 16:07 Pujan92

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jul 10 '24 10:07 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/44628

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @Pujan92 does not require payment (Contractor)
  • @koko57 does not require payment (Contractor)

melvin-bot[bot] avatar Jul 10 '24 10:07 melvin-bot[bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
  • [ ] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [ ] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [ ] [@Pujan92] Determine if we should create a regression test for this bug.
  • [ ] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [ ] [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] avatar Jul 10 '24 10:07 melvin-bot[bot]

Thanks @Pujan92 ! Could you complete the BZ checklist when you have a chance? Thanks! 😃

OfstadC avatar Jul 10 '24 19:07 OfstadC

@OfstadC I believe that will be handled in the parent issue https://github.com/Expensify/App/issues/36648

Pujan92 avatar Jul 10 '24 19:07 Pujan92

Ah okay! 😅 Thanks @Pujan92 !

OfstadC avatar Jul 11 '24 18:07 OfstadC

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/44628

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @Pujan92 does not require payment (Contractor)
  • @koko57 does not require payment (Contractor)

melvin-bot[bot] avatar Jul 15 '24 20:07 melvin-bot[bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
  • [ ] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [ ] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [ ] [@Pujan92] Determine if we should create a regression test for this bug.
  • [ ] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [ ] [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] avatar Jul 15 '24 20:07 melvin-bot[bot]

Closing this out -

No payment needed per:

For reference, here are some details about the assignees on this issue:

@Pujan92 does not require payment (Contractor) @koko57 does not require payment (Contractor)

And checklist should be covered here

OfstadC avatar Jul 17 '24 18:07 OfstadC