App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Xero - "Can't connect to Xero." error message appears briefly before connecting

Open lanitochka17 opened this issue 1 year ago β€’ 15 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.86-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4653112&group_by=cases:section_id&group_id=309134&group_order=asc Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new expensifail account
  3. Create a workspace
  4. Enable Accounting
  5. Navigate to Workspace settings - Accounting
  6. Connect to Xero

Expected Result:

I should be able to connect without any error messages

Actual Result:

"Can't connect to Xero." error message appears briefly before connecting. Affects Gmail and expensifail accounts too.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/943516af-d8e7-4e96-90d1-e5d13ecbba40

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4b2bfe4b91b5ac9
  • Upwork Job ID: 1805137190641025234
  • Last Price Increase: 2024-07-08

lanitochka17 avatar Jun 21 '24 12:06 lanitochka17

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 21 '24 12:06 melvin-bot[bot]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Jun 21 '24 12:06 lanitochka17

We think that this bug might be related to #wave-collect - Release 2

lanitochka17 avatar Jun 21 '24 12:06 lanitochka17

Job added to Upwork: https://www.upwork.com/jobs/~01c4b2bfe4b91b5ac9

melvin-bot[bot] avatar Jun 24 '24 07:06 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

melvin-bot[bot] avatar Jun 24 '24 07:06 melvin-bot[bot]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jun 27 '24 18:06 melvin-bot[bot]

Waiting for proposals

alitoshmatov avatar Jun 27 '24 20:06 alitoshmatov

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jul 01 '24 16:07 melvin-bot[bot]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jul 01 '24 18:07 melvin-bot[bot]

Still waiting for proposals

alitoshmatov avatar Jul 03 '24 10:07 alitoshmatov

@kadiealexander @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jul 05 '24 18:07 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jul 08 '24 16:07 melvin-bot[bot]

@kadiealexander, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jul 08 '24 18:07 melvin-bot[bot]

Requested a retest here.

kadiealexander avatar Jul 09 '24 05:07 kadiealexander

Reproducible on build 9.0.5-7.

https://github.com/Expensify/App/assets/93399543/cc9b16b6-0d33-4832-8295-21dcd9f1b343

kbecciv avatar Jul 09 '24 12:07 kbecciv

Still not overdue.

kadiealexander avatar Jul 12 '24 01:07 kadiealexander

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jul 15 '24 16:07 melvin-bot[bot]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jul 15 '24 18:07 melvin-bot[bot]

Not overdue.

kadiealexander avatar Jul 16 '24 04:07 kadiealexander

I can still reproduce:

https://github.com/user-attachments/assets/fd0fd920-6ddf-4004-a70e-9bcf04d60277

@alitoshmatov do you think this can be fixed entirely on the front end?

kadiealexander avatar Jul 19 '24 00:07 kadiealexander

@kadiealexander @alitoshmatov this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Jul 19 '24 18:07 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jul 22 '24 16:07 melvin-bot[bot]

@kadiealexander, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 22 '24 18:07 melvin-bot[bot]

@alitoshmatov bump on my question above.

kadiealexander avatar Jul 22 '24 21:07 kadiealexander

Hi! I am Jakub from Callstack - expert contributor group. I’d like to work on this issue.

@kadiealexander Can I get some credentials to connect to Xero? And are there any other requirements to reproduce that issue?

kubabutkiewicz avatar Jul 25 '24 06:07 kubabutkiewicz

Hi Jakub! That's all that is needed to reproduce. Do you have access to our 1password environment?

kadiealexander avatar Jul 26 '24 04:07 kadiealexander

πŸ“£ @alitoshmatov πŸŽ‰ An offer has been automatically sent to your Upwork account for the Reviewer role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Jul 26 '24 04:07 melvin-bot[bot]

@kadiealexander no, I dont have

kubabutkiewicz avatar Jul 26 '24 07:07 kubabutkiewicz

@kubabutkiewicz try to connect to Xero and then choose the Xero demo company option.

trjExpensify avatar Jul 26 '24 12:07 trjExpensify

I'm not sure if that option is there anymore, but if not.. just start a 30 day free trial: https://www.xero.com/uk/signup/

trjExpensify avatar Jul 26 '24 12:07 trjExpensify