App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

Fix: Workspace member has option to edit categories

Open daledah opened this issue 1 year ago • 24 comments

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43623 PROPOSAL: https://github.com/Expensify/App/issues/43623#issuecomment-2165303496

Tests

Precondition: User should have an workspace with all categories Disabled:

  1. Go to FAB > Track expense.
  2. Track a manual expense.
  3. In self-DM Click Categorize it from the actionable whisper.
  4. Verify that: the workspace without categories isn't an option
  • [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • [x] Verify that no errors appear in the JS console

PR Author Checklist

  • [x] I linked the correct issue in the ### Fixed Issues section above
  • [x] I wrote clear testing steps that cover the changes made in this PR
    • [x] I added steps for local testing in the Tests section
    • [x] I added steps for the expected offline behavior in the Offline steps section
    • [x] I added steps for Staging and/or Production testing in the QA steps section
    • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I ran the tests on all platforms & verified they passed on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [x] I followed proper code patterns (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I followed the guidelines as stated in the Review Guidelines
  • [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/171708823/c5ac6144-2cee-478f-bc96-7f14e067df4e

Android: mWeb Chrome

https://github.com/Expensify/App/assets/171708823/315f248e-a3b3-40e8-8fcb-b6981fb7ce9e

iOS: Native

https://github.com/Expensify/App/assets/171708823/659dfa4f-2397-413d-8263-70b11270925b

iOS: mWeb Safari

https://github.com/Expensify/App/assets/171708823/0526ca95-81e7-46d5-ba53-fe8b839ea31e

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/171708823/3b724b10-6ba6-4a77-8563-7cb208dcbddd

MacOS: Desktop

https://github.com/Expensify/App/assets/171708823/26ee2546-00ac-47c7-a046-3c3c2c583d1b

daledah avatar Jun 19 '24 04:06 daledah

@dannymcclain @allgandalf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Jun 19 '24 08:06 melvin-bot[bot]

[!IMPORTANT]
@daledah, the new expected result from this PR is as follows: not show workspaces that don't have any categories enabled in the list of workspaces when you select Categorize from Concierge's suggested actions

Slack link

allgandalf avatar Jun 20 '24 20:06 allgandalf

friendly bump @daledah

allgandalf avatar Jun 21 '24 17:06 allgandalf

i'll update today

daledah avatar Jun 24 '24 02:06 daledah

@allgandalf i updated, please check again with my solution

daledah avatar Jun 24 '24 08:06 daledah

@daledah can you update the Videos on all platforms, they still seem to be on the old logic

allgandalf avatar Jun 25 '24 09:06 allgandalf

Sorry for delay, I'll update today

daledah avatar Jun 28 '24 09:06 daledah

@allgandalf i updated, please check again 🙏

daledah avatar Jun 28 '24 10:06 daledah

@allgandalf i updated

daledah avatar Jul 01 '24 14:07 daledah

Thanks for updating i will review this tomorrow, working on other high priority PR's today

allgandalf avatar Jul 01 '24 18:07 allgandalf

This has conflicts @daledah

allgandalf avatar Jul 03 '24 18:07 allgandalf

@daledah friendly bump

allgandalf avatar Jul 04 '24 17:07 allgandalf

@allgandalf i updated

daledah avatar Jul 05 '24 03:07 daledah

I’m under the weather and also reviewing a PR related to Onboarding, so will take the night after that, i will review this tomorrow

allgandalf avatar Jul 08 '24 17:07 allgandalf

@neil-marcellini i updated

daledah avatar Jul 09 '24 03:07 daledah

@allgandalf since your comments don't relate to the functionality of the code, would you please also test now and hopefully we can get this merged soon? We can fix small things in a follow up if needed.

neil-marcellini avatar Jul 09 '24 16:07 neil-marcellini

works for me, starting review now

allgandalf avatar Jul 09 '24 16:07 allgandalf

Reviewer Checklist

  • [x] I have verified the author checklist is complete (all boxes are checked off).
  • [x] I verified the correct issue is linked in the ### Fixed Issues section above
  • [x] I verified testing steps are clear and they cover the changes made in this PR
    • [x] I verified the steps for local testing are in the Tests section
    • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
    • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I checked that screenshots or videos are included for tests on all platforms
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I verified tests pass on all platforms & I tested again on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • [x] I verified proper code patterns were followed (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
  • [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] If a new component is created I verified that:
    • [x] A similar component doesn't exist in the codebase
    • [x] All props are defined accurately and each prop has a /** comment above it */
    • [x] The file is named correctly
    • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • [x] The only data being stored in the state is data necessary for rendering and nothing else
    • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • [x] All JSX used for rendering exists in the render method
    • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/c4edf041-7dc8-4154-80a1-72aef9b9bd94

Android: mWeb Chrome

https://github.com/user-attachments/assets/19898901-d29b-4dfc-b489-d8ebdd24204f

iOS: Native

https://github.com/user-attachments/assets/aba3765e-ee22-4724-924e-69cd515d44b0

iOS: mWeb Safari

https://github.com/user-attachments/assets/04e1abe6-382d-43e6-a978-679d6b750187

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b40b437a-37dd-4666-ac63-23981fe0c05e

MacOS: Desktop

https://github.com/user-attachments/assets/e32036a6-662e-4343-98f6-1e32c14d15eb

allgandalf avatar Jul 09 '24 16:07 allgandalf

@neil-marcellini , i guess you have the access to edit the PR description, can you please update the QA steps to:

Precondition: User should have an workspace with all categories Disabled:

  1. Go to FAB > Track expense.
  2. Track a manual expense.
  3. In self-DMClick Categorize it from the actionable whisper.
  4. Verify that: the workspace without categories isn't an option

allgandalf avatar Jul 09 '24 16:07 allgandalf

Bug

Workspaces with enabled categories are seen twice:

Screenshot 2024-07-09 at 10 20 41 PM

allgandalf avatar Jul 09 '24 16:07 allgandalf

@allgandalf I can't reproduce this bug. Please add detailed steps.

https://github.com/Expensify/App/assets/171708823/f5a1bda1-7a5f-4819-a9d5-c4835fb257f1

daledah avatar Jul 09 '24 23:07 daledah

Steps to reproduce:

  1. Login with new account
  2. create new workspace
  3. Disable the categories of the new workspace
  4. Create another workspace
  5. Go to FAB and select track expense
  6. Go to self DM and select the whisper: Categorize it
  7. Observe that you see the same workspaces with enabled categories appear twice

https://github.com/Expensify/App/assets/110545952/91b06059-4eb3-431b-85b2-424614275b4c

allgandalf avatar Jul 10 '24 08:07 allgandalf

Bug

Workspaces with enabled categories are seen twice:

@allgandalf This bug also appears in main, it seems unrelated to my PR. Looks like after creating a new workspace, all channels are duplicated, so the suggestions are also duplicated.

https://github.com/Expensify/App/assets/171708823/7643b060-d4e8-4a2b-a20f-1b7464acfe11

daledah avatar Jul 11 '24 15:07 daledah

@allgandalf This bug also appears in main, it seems unrelated to my PR. Looks like after creating a new workspace, all channels are duplicated, so the suggestions are also duplicated.

This bug doesn't appear on main @daledah , the video which you attached is on local dev environment, I tested on staging and production the reported bug doesn't appear there:

https://github.com/Expensify/App/assets/110545952/d6b5a380-5a50-43c8-9d91-cadf0d3d880e

So i guess the bug which is mentioned here is indeed a regression of our PR, can you please take a look at this @daledah 🙏

c.c. @neil-marcellini

allgandalf avatar Jul 11 '24 19:07 allgandalf

@allgandalf can you check with your latest main on local dev environment This video below is from my latest main and we have a bug when creating a new workspace I think our PR code changes aren't related to this bug cc @neil-marcellini

https://github.com/user-attachments/assets/db8d1380-964b-44e5-a914-1162ad765095

daledah avatar Jul 12 '24 07:07 daledah

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify avatar Jul 15 '24 18:07 OSBotify

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.7-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Jul 15 '24 21:07 OSBotify

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify avatar Jul 15 '24 22:07 OSBotify

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

OSBotify avatar Jul 17 '24 00:07 OSBotify

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Jul 18 '24 13:07 OSBotify