[$250] Track Distance - Track distance rate updated with no error when user change it offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4626788&group_by=cases:section_id&group_order=asc&group_id=229065 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

1. On the main testing device, navigate to Workspace settings > More features
2. Enable "Distance rates"
3. Navigate to the Distance rates tab
4. Turn off the internet connection on the device
5. Change the Distance rate to any number
6. Verify the field is grayed out after entering the number, indicating it's pending to be updated
7. Secondary device - navigate to Workspace settings > More features
8. Navigate to the Distance rates tab
9. Change the distance rate
10. On the main testing device - Enable the internet connection

Expected Result:

There should be a message indicating something went wrong and to reload the page and try again

Actual Result:

No error message when user from main device change the rate in offline, and secondary login change it in online mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/4f181bb3-3389-40f3-9033-b6d706c7584d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015b628ae26068ff0f
• Upwork Job ID: 1803189008217375274
• Last Price Increase: 2024-06-25
• Automatic offers:
• paultsimura | Contributor | 102912105

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot[bot]]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Whoah missed this.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~015b628ae26068ff0f

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot[bot]]

@twisterdotcom, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[twisterdotcom]

Leaving 250, but downgrading to weekly. Adding to wave collect.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@twisterdotcom @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

Tracking offline distance issues here @paultsimura , who has worked on the feature, is going to review and address all these, please comment so I can assign. Removing Help Wanted for now.

[paultsimura]

👋🏼

[melvin-bot[bot]]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

To me, this looks like a mostly BE issue: if the expected behavior is correct, we should fail the request on the BE side and handle the failure on the client in a corresponding way (discard the optimistic change and show the error).

[twisterdotcom]

@thesahindia do you agree?

[thesahindia]

I think we need to confirm the expected result first.

[melvin-bot[bot]]

@twisterdotcom @paultsimura @thesahindia this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[thesahindia]

Oh it looks like @paultsimura is assigned as the C+ here. I am gonna unassign myself.

[paultsimura]

@thesahindia I was not a C+ here, I was assigned as a mere contributor🥲

[twisterdotcom]

Looking back on this now with fresh eyes, I don't think this is a bug. If you make a change offline and a subsequent online change occurs to that setting before you come online, I'm not sure we need to show anything to the offline user when they come back online, do we? Because their edit is queued and happens after theirs is the one that sticks now.

This is the same as if two admins on separate devices just changed it at different times. The good thing is we log these changes in the admins room, so I don't think we need to do anything here actually.