App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Tag - Dependent tag violation message isn't changing to "all tags required"

Open kavimuru opened this issue 1 year ago โ€ข 22 comments

If you havenโ€™t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when validating #40741 Version Number: 1.4.82-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition: Import the attached dependent_tags.csv in OD for a workspace. Enable multi level tags.

  1. Navigate to https://staging.new.expensify.com/

  2. Log in with an expensifail account

  3. Navigate to the workspace chat

  4. Start submitting a manual expense

  5. Only input the "Merchant" field on the confirmation page

  6. Submit the expense

  7. Open the expense

  8. Click on any of the three missing tags

  9. Choose any of the options

Expected Result:

The message should change to "all tags required" for the reported missing tags.

Actual Result:

Dependent tag violation message isn't changing to "all tags required" for the rest of the tags when there are multiple missing tags and one is selected.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Bug6510487_1718181753132!dependent_tags.csv

https://github.com/Expensify/App/assets/43996225/91868197-e7a8-4279-8500-0294663a5fb3

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013b410860cea8f950
  • Upwork Job ID: 1801658425666734007
  • Last Price Increase: 2024-07-05

kavimuru avatar Jun 12 '24 14:06 kavimuru

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 12 '24 14:06 melvin-bot[bot]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

kavimuru avatar Jun 12 '24 14:06 kavimuru

We think this bug might be related to #wave-collect - Release 1

kavimuru avatar Jun 12 '24 14:06 kavimuru

Also got this: https://github.com/Expensify/App/issues/38682.

twisterdotcom avatar Jun 13 '24 23:06 twisterdotcom

Job added to Upwork: https://www.upwork.com/jobs/~013b410860cea8f950

melvin-bot[bot] avatar Jun 14 '24 16:06 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

melvin-bot[bot] avatar Jun 14 '24 16:06 melvin-bot[bot]

@twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jun 17 '24 18:06 melvin-bot[bot]

Waiting on proposal

sobitneupane avatar Jun 18 '24 06:06 sobitneupane

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jun 21 '24 16:06 melvin-bot[bot]

@twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jun 21 '24 18:06 melvin-bot[bot]

Waiting for proposal

sobitneupane avatar Jun 24 '24 07:06 sobitneupane

@twisterdotcom @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jun 26 '24 18:06 melvin-bot[bot]

Still waiting on proposals. May be addressed eventually with Control functionality.

twisterdotcom avatar Jun 26 '24 23:06 twisterdotcom

Waiting for proposal

sobitneupane avatar Jun 27 '24 06:06 sobitneupane

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jun 28 '24 16:06 melvin-bot[bot]

@twisterdotcom, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jul 02 '24 18:07 melvin-bot[bot]

Waiting for proposal

sobitneupane avatar Jul 03 '24 06:07 sobitneupane

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jul 05 '24 16:07 melvin-bot[bot]

Still waiting

twisterdotcom avatar Jul 05 '24 17:07 twisterdotcom

@twisterdotcom, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 08 '24 18:07 melvin-bot[bot]

Waiting for proposal

sobitneupane avatar Jul 09 '24 07:07 sobitneupane

@twisterdotcom @sobitneupane this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Jul 10 '24 18:07 melvin-bot[bot]

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jul 12 '24 16:07 melvin-bot[bot]

@twisterdotcom, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 12 '24 18:07 melvin-bot[bot]

Waiting for proposal

sobitneupane avatar Jul 15 '24 07:07 sobitneupane

@twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jul 18 '24 18:07 melvin-bot[bot]

Waiting for proposal

sobitneupane avatar Jul 19 '24 06:07 sobitneupane

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jul 19 '24 16:07 melvin-bot[bot]

Still waiting. Gonna make this weekly.

twisterdotcom avatar Jul 22 '24 13:07 twisterdotcom

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] avatar Jul 26 '24 16:07 melvin-bot[bot]