App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD #14676] Chat - Strikethrough markdown is applied to emojis on compose box

Open kavimuru opened this issue 1 year ago • 14 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.80-14 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4606688 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Pre-requisite: user must be logged in.

  1. Go to any chat.
  2. Tap on the compose box.
  3. Enter " ~test (emoji) test~ ".
  4. Verify the markdown is applied to the emoji on the compose box.
  5. Send the message.
  6. Verify the markdown is not applied to the emoji on the chat.

Expected Result:

The strikethrough markdown should not be applied to emojis on the compose box.

Actual Result:

The strikethrough markdown is applied to emojis on the compose box.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/43996225/07f4cb32-b1c3-436d-a68b-7f65f3bdd582

View all open jobs on GitHub

kavimuru avatar Jun 07 '24 21:06 kavimuru

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 07 '24 21:06 melvin-bot[bot]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

kavimuru avatar Jun 07 '24 21:06 kavimuru

We think this bug might be related to 3vip-vsb

kavimuru avatar Jun 07 '24 21:06 kavimuru

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Jun 10 '24 22:06 MelvinBot

Holding on the below

  • https://github.com/Expensify/App/issues/14676

mallenexpensify avatar Jun 10 '24 22:06 mallenexpensify

https://github.com/Expensify/App/issues/14676 Still open

mallenexpensify avatar Jun 21 '24 21:06 mallenexpensify

holding

mallenexpensify avatar Jul 03 '24 01:07 mallenexpensify

Bumped to monthly cuz the issue we're held on isn't a priority https://github.com/Expensify/App/issues/14676

mallenexpensify avatar Jul 17 '24 00:07 mallenexpensify

Still holding

  • https://github.com/Expensify/App/issues/14676

mallenexpensify avatar Aug 21 '24 00:08 mallenexpensify

Checking back ~monthly on the help issue

mallenexpensify avatar Sep 24 '24 22:09 mallenexpensify

@mallenexpensify QA team found a similar issue, but the emoji is strikethrough after it had been sent too. Do we need to raise a new issue or is it the same as above?

https://github.com/user-attachments/assets/6518fe22-bf57-4cc9-a069-66b0120e21dc

IuliiaHerets avatar Oct 08 '24 07:10 IuliiaHerets

No need for a separate issue @IuliiaHerets , best to keep in this one (for if/when we prioritize). Thx

mallenexpensify avatar Oct 09 '24 00:10 mallenexpensify

Off the next week, in case this goes overdue

mallenexpensify avatar Nov 06 '24 21:11 mallenexpensify

Below is the PR from the issue we're held on, it's under review

  • https://github.com/Expensify/react-native-live-markdown/pull/534

mallenexpensify avatar Dec 11 '24 00:12 mallenexpensify

Closing, for now, from this PR

We decided to close this PR and rewrite the solution to TypeScript at https://github.com/Expensify/react-native-live-markdown/pull/591. After the discussion, we agreed that after enabling custom parsers in the live markdown library, it would be better not to interfere with their results. Because of that, we moved the range splitting algorithm to the parseExpensiMark so all platforms get the split ranges. It also gives a choice in custom parser implementation if someone wants to remove styles from emojis

mallenexpensify avatar Jan 15 '25 01:01 mallenexpensify