Expensify
[Hold E/E #404210] Workspace - "Hidden" members appear in the list when a member leaves
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.75-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/41492
Action Performed:
- Admin: Log in as a new expensifail user
- Member: Log in as a new Gmail user in a different device
- Admin: Create a workspace
- Admin: Invite the member to the workspace
- Admin: Navigate to the Workspace member list page
- Admin: Open the member details page
- Member: Leave the workspace
- Admin: Click on "Go back to home page"
Expected Result:
Only real members of the workspace should be shown
Actual Result:
"Hidden" members appear in the list when a workspace member leaves
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/6638fe81-83c0-4f02-996a-b9fac2ab0b09
Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@trjExpensify Hi, I took a look, this is not a regresison from that PR because reverting it does not solve the issue.
This is a BE problem. I notice that when the employee left the workspace, the Pusher sent to admin a very strange policy.employeeList value:
employeeList is supposed to be a object mapping from an user's login to his details, but in this case, it's [email protected] which is a part of the employee's login ([email protected]). I hope this helps with the debugging in BE.
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Alright, so looks like this was missed. Members should be able to leave a workspace unless they're under domain control on both NewDot and OldDot.
This issue provides a bit of history on why that wasn't the case with a helpful comment from @iwiznia. That said, a lot has changed since then and Auth is aware of the employeeList now. 👍
Sending Internal.
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@Beamanator with the approvals work and behaviour around leaving a workspace, will this be cleaned up? I think it's somewhat linked to this weird dynamic of allowing someone to "leave" workspace on NewDot but not properly handled on the backend, as you can't do that on OldDot.
I thinkkkkk you're right and yes it "should get fixed" with those changes, but I would recommend we keep this open (maybe drop to weekly / monthly) to make sure this doesn't accidentally slip by, unfixed
Yep, makes sense. Do you have a particular issue I can point to for the hold?
Okay, the issue linked has merged. Adding retest weekly label for QA to re-test this to confirm it has been fixed.
Okay, so that wasn't fixed then @Beamanator. Let's make sure it's taken care of in here then I guess?