App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD #38625] Unable to delete newly created workspace in new account

Open m-natarajan opened this issue 1 year ago • 52 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.68-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @Puneet-here Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714499352473189

Action Performed:

  1. Created a new account in staging.new.expensify.com
  2. Create a new workspace
  3. Select the created workspace
  4. Click three dot menu and delete the workspace

Expected Result:

Workspace deleted

Actual Result:

Unable to delete workspace and "Looks like you're on an annual subscription. Please downgrade your account from your account settings before trying again" error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [X] MacOS: Chrome / Safari
  • [X] MacOS: Desktop

Screenshots/Videos

image (21)

https://github.com/Expensify/App/assets/38435837/729b33b0-6485-4708-a5b6-100dde9f2e54

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fc08a6832d88aa3c
  • Upwork Job ID: 1785688967359610880
  • Last Price Increase: 2024-05-22

m-natarajan avatar Apr 30 '24 20:04 m-natarajan

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Apr 30 '24 20:04 melvin-bot[bot]

I ran into this myself today.

  1. I was able to delete the same workspace on OldDot, but not NewDot.
  2. I checked I was still in the 7-day free trial window

Logs are here (internal only, sorry).

Throw ExpException - a8948deec2009297362f103209a7a026 ~~ message: '401 Can't delete last policy under a yearly subscription' exceptionMessage: 'Auth DeletePolicy returned an error' exceptionFile: '/git/releases/expensify.com/64247c4/lib/Auth.php' exceptionLine: '125' exceptionCode: '401'

I'm hitting this block when I don't think I should be: https://github.com/Expensify/Auth/blob/01554c45bd48e4cae90b02a23e96f943cb90698c/auth/lib/Policy.cpp#L2755-L2761

So I think somehow NewDot isn't recognising that the workspace I'm trying to delete is on a free trial and it's throwing this error.

trjExpensify avatar May 01 '24 15:05 trjExpensify

Job added to Upwork: https://www.upwork.com/jobs/~01fc08a6832d88aa3c

melvin-bot[bot] avatar May 01 '24 15:05 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

melvin-bot[bot] avatar May 01 '24 15:05 melvin-bot[bot]

Sending external for more eyes.

trjExpensify avatar May 01 '24 15:05 trjExpensify

Looks like a backend issue, i'll try to reproduce and confirm.

getusha avatar May 03 '24 19:05 getusha

@dylanexpensify, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar May 07 '24 01:05 melvin-bot[bot]

@getusha did we confirm?

dylanexpensify avatar May 07 '24 11:05 dylanexpensify

I am unable to reproduce, @m-natarajan is there a prerequisite for the account?

https://github.com/Expensify/App/assets/75031127/d2a9efad-5f9b-4fb2-bbe4-71433a72a2c7

getusha avatar May 07 '24 13:05 getusha

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar May 08 '24 16:05 melvin-bot[bot]

@dylanexpensify, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar May 10 '24 18:05 melvin-bot[bot]

bump @m-natarajan

dylanexpensify avatar May 14 '24 12:05 dylanexpensify

@dylanexpensify @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar May 14 '24 18:05 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar May 15 '24 16:05 melvin-bot[bot]

@dylanexpensify This is still reproducible on our side. Applause Automation team reported seeing this issue ~2 hours ago

image

isagoico avatar May 17 '24 15:05 isagoico

@dylanexpensify, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar May 17 '24 18:05 melvin-bot[bot]

@dylanexpensify, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar May 21 '24 18:05 melvin-bot[bot]

ah interesting, @MitchExpensify a collect workspace on a free trial be able to delete, right? Asking given your work with free trials

dylanexpensify avatar May 21 '24 20:05 dylanexpensify

Yep, and the bug is on NewDot only weirdly.

trjExpensify avatar May 21 '24 20:05 trjExpensify

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar May 22 '24 16:05 melvin-bot[bot]

a collect workspace on a free trial be able to delete, right?

Correct

MitchExpensify avatar May 26 '24 20:05 MitchExpensify

@dylanexpensify, @getusha Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar May 27 '24 18:05 melvin-bot[bot]

I think it's better to make this internal. @dylanexpensify

getusha avatar May 28 '24 11:05 getusha

@dylanexpensify @getusha this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar May 28 '24 18:05 melvin-bot[bot]

Moving internal. Will post for volunteers/hot pick!

dylanexpensify avatar May 29 '24 06:05 dylanexpensify

@dylanexpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Jun 03 '24 19:06 melvin-bot[bot]

Internal, not overdue

getusha avatar Jun 04 '24 07:06 getusha

Still waiting

dylanexpensify avatar Jun 05 '24 09:06 dylanexpensify

@dylanexpensify, @getusha Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jun 10 '24 18:06 melvin-bot[bot]

same

dylanexpensify avatar Jun 11 '24 10:06 dylanexpensify