App crashes while trying to join public room via deep link

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found validating #40701 Version Number: 1.4.67-0 Reproducible in staging?: y Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

1. Open any chat and paste Public room link (e.g. https://staging.new.expensify.com/r/2652281908731856)
2. Click on the link
3. if the issue not reproduced - leave the room and click on the link again

Expected Result:

The user should be able to join Public rooms via deep link

Actual Result:

in 50/50 times the app crashes in case of use Public room deep link

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/cf16a61f-628e-4f69-880f-bee1d721e819

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #vip-vsb

[twisterdotcom]

I can actually never get this to work if I'm not a member of the room already, I ALWAYS hit this {"jsonCode":407,"title":"Session expired","message":"Your session has expired. Please sign in again.","requestID":"87beeeb619a894a6-LHR"}

[twisterdotcom]

Sometimes I'll get

{"code":666,"jsonCode":403,"type":"Expensify\Libs\Error\ExpError","UUID":"da7984df-628f-41f6-a2b8-ecd4499f7975","message":"Report not found","title":"","data":{"onyxData":[{"onyxMethod":"merge","key":"report_0","value":{"errorFields":{"notFound":{"1714390877809894":"Report not found"}}}}]},"htmlMessage":"","requestID":"87bf05a98be594a6-LHR"}` as well.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e9d522b8dfa6acfe

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[twisterdotcom]

@puneetlath and @Ollyws - any idea why this regression is happening?

[twisterdotcom]

@MonilBhavsar are we reverting https://github.com/Expensify/App/pull/40701 - do we need somebody assigned here externally or not?

[Nodebrute]

@twisterdotcom I think this should be resolved here https://github.com/Expensify/App/issues/41128

[MonilBhavsar]

are we reverting https://github.com/Expensify/App/pull/40701 - do we need somebody assigned here externally or not?

No, because it didn't cause or reverting it doesn't fix this issue https://github.com/Expensify/App/pull/40701#issuecomment-2081975107

[twisterdotcom]

Okay, so it's not due to https://github.com/Expensify/App/pull/40701 and @MonilBhavsar doesn't think it's resolved by https://github.com/Expensify/App/issues/41128, so we definitely need to look into this.

[MonilBhavsar]

Making a quick fix for this crash...

[melvin-bot[bot]]

Current assignee @Ollyws is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MonilBhavsar]

Tested and it works fine now

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.67-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/41219

If no regressions arise, payment will be issued on 2024-05-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Ollyws] Determine if we should create a regression test for this bug.
• [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@puneetlath / @twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

I don't think @Ollyws needs paying out here, this was reviewed by @puneetlath.

@MonilBhavsar or @puneetlath do we need a test here too? I think we already have tests but perhaps we could just use the QA steps from https://github.com/Expensify/App/pull/40701?

1. Create a public room as an admin
2. As a user A, join the public room
3. Copy the public room URL and signout
4. Paste the URL and signin
5. Leave the room
6. Ensure you're redirected to Concierge chat
7. As a user A, join the public room again
8. This time visit two other reports - X and Y and then go to public room
9. Leave the room
10. Ensure you're redirected to report Y
11. Create a group as an admin with user A and user B
12. As a user B visit the group
13. Click on group title and Leave the group
14. Ensure you're redirected to last visited report

[MonilBhavsar]

Yes, looks good 👍

[puneetlath]

Sounds good to me!

[twisterdotcom]

All done

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.68-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/41219

If no regressions arise, payment will be issued on 2024-05-08. :confetti_ball:

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@puneetlath / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@puneetlath / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@puneetlath / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@puneetlath / @MonilBhavsar] Determine if we should create a regression test for this bug.
• [ ] [@puneetlath / @MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@puneetlath / @twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Already done.