fix: Workspace switcher search bar is in the wrong place.

[Krishna2323]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40826 PROPOSAL: https://github.com/Expensify/App/issues/40826#issuecomment-2073381702

Tests

• [ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

• [ ] Verify that no errors appear in the JS console

PR Author Checklist

• [ ] I linked the correct issue in the ### Fixed Issues section above
• [ ] I wrote clear testing steps that cover the changes made in this PR
  • [ ] I added steps for local testing in the Tests section
  • [ ] I added steps for the expected offline behavior in the Offline steps section
  • [ ] I added steps for Staging and/or Production testing in the QA steps section
  • [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [ ] I included screenshots or videos for tests on all platforms
• [ ] I ran the tests on all platforms & verified they passed on:
  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop
• [ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [ ] I followed proper code patterns (see Reviewing the code)
  • [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [ ] I verified that comments were added to code that is not self explanatory
  • [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [ ] I followed the guidelines as stated in the Review Guidelines
• [ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [ ] I verified that if a function's arguments changed that all usages have also been updated correctly
• [ ] If any new file was added I verified that:
  • [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [ ] If a new CSS style is added I verified that:
  • [ ] A similar style doesn't already exist
  • [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [ ] I verified that all the inputs inside a form are aligned with each other.
  • [ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot[bot]]

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

After fix:

Everything Selected	Workspace Selected

cc: @Expensify/design

[Krishna2323]

In the design the input placeholder is Find a workspace and there is a search icon on the left of the input, do we need that as well?

[getusha]

@Expensify/design could you please confirm if this is looking as expected? thanks!

[shawnborton]

Hmm if we do want to add the icon, I would say we should add it to the right side of the input. Can you try that and show us what it looks like?

[getusha]

@Krishna2323 any updates?

[Krishna2323]

can you try that and show us what it looks like?

@shawnborton @getusha, IMO, we shouldn't add this because no other input in the app has this icon, or if we want, we can add this as default for every selection list input.

[shawnborton]

IMO, we shouldn't add this because no other input in the app has this icon, or if we want, we can add this as default for every selection list input.

I actually don't mind the idea of making it so that every search box above a selection list uses that same style, which has the magnifying glass. What do you think @Expensify/design ? The alternative is to just omit the Search icon entirely, but I do think the icon helps this particular component look more like a search box and less like a heading.

[dannymcclain]

I actually don't mind the idea of making it so that every search box above a selection list uses that same style, which has the magnifying glass.

Yeah I don't think that's a bad idea at all. At the same time, the right side in this workspace switcher is looking a little crazy, so I could be persuaded to drop the icon as well. I'll be happy with whatever you and @dubielzyk-expensify think is best!

[shawnborton]

True, but that's a good point - maybe we just need the search icon to be properly aligned all the way to the right side of the input. @Krishna2323 can you try that please?

[Krishna2323]

@dannymcclain @shawnborton, currently the search icon has 8px padding right, if we remove the padding right from the icon it will still not look aligned with above 2 icons, so I reduced it to 4px instead.

Padding right 4px

No Padding

[shawnborton]

Hmm that feels like a strange exception to make though, because we can't always guarantee these kinds of inputs will be in the same view as those kinds of list items. So I think I would prefer we just drop the icon altogether if that's the case.

[dannymcclain]

Hmm that feels like a strange exception to make though, because we can't always guarantee these kinds of inputs will be in the same view as those kinds of list items. So I think I would prefer we just drop the icon altogether if that's the case.

Yeah same.

[dubielzyk-expensify]

Feels like you landed in a good place by dropping it. Makes sense to me 👍

[Krishna2323]

@getusha, I think we don't want to make any changes here, can you pls start reviewing.

[getusha]

I think we missed a case, we should include the Everything option to be selectable using a keyboard

https://github.com/Expensify/App/assets/75031127/b5292f5c-104b-4b7d-93a9-fa572beeba3e

[Krishna2323]

@getusha, including the Everything option as a selectable using keyboard will be tricky, can we pls confirm if that is required.

cc: @shawnborton @rlinoz

[dannymcclain]

Personally I don't think Everything would be selected via keyboard just by using the arrows keys in the list. I would expect to have to tab up to it. Just my 2 cents.

[shawnborton]

Yup, I agree with that

[Krishna2323]

@dannymcclain @shawnborton thanks!

@getusha, you can continue the review.

[Krishna2323]

@getusha, bump for review.

[getusha]

BUG: the search input is blurred after opening the workspace switcher

https://github.com/Expensify/App/assets/75031127/a86e5742-3425-4b27-9ee5-89f57f2ae816

[getusha]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[getusha]

@Krishna2323 the search input is not perfectly aligned, it has unwanted padding-left could you compare it with staging?

[dubielzyk-expensify]

The above screenshot brings up an interesting point, cause I'd expect everything to align to the left anchor point of this red line:

So if we chuck the search input in there we'll end up with uneven alignment whether we align it to the workspace avatar or the section header. I'd perfer if everything just has 20px padding from the edge and is aligned the same.

Keen for thoughts from @Expensify/design here on this though

[Krishna2323]

@dubielzyk-expensify @getusha, does this look correct?

[getusha]

it looks good to me cc @Expensify/design

[dannymcclain]

I'd perfer if everything just has 20px padding from the edge and is aligned the same.

100% agree with Jon.

I think it's looking good—here's a little screenshot with 20px rectangles on the left and right to help visualize the alignment in this comment.

[shawnborton]

Also for this one:

the search input is not perfectly aligned, it has unwanted padding-left could you compare it with staging?

Can you pull main? We recently merged this one which might fix some of those issues. Particularly this comment here.

[dubielzyk-expensify]

Yep that looks good to me. Defs do what @shawnborton said as well.

Last question for design. Do we want the search icon on the right of the input field or not? I know we've gone back and forth on that one, but forget if we made a call.