[$250] IOS - More features - Enabled feature is not showing in workspace page after enabling it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.67-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to Account settings > Workspaces
3. Create a new workspace
4. Go to More features
5. Enable any feature

Expected Result:

App will redirect to the previous page with the enabled feature

Actual Result:

The enabled feature is not showing in workspace page after enabling it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e6867546-b84e-4c84-bbd3-af33a6b048ac

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011cc719021a75da07
• Upwork Job ID: 1784283404020502528
• Last Price Increase: 2024-04-27

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[roryabraham]

This does appear to be a deploy-blocking bug. Going to make it external now

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~011cc719021a75da07

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - More features - Enabled feature is not showing in workspace page after enabling it

What is the root cause of that problem?

Offending PR: https://github.com/Expensify/App/pull/40369

In the PR mentioned above we introduced didScreenTransitionEnd to delay the transition start so it only starts after navigation transition is ended, but due to this bug in navigation, didScreenTransitionEnd is not correctly updated in iOS. I haven't found the exact reason why does this happen.

What changes do you think we should make in order to solve the problem?

We should remove didScreenTransitionEnd check and instead use setTimeout or itemEnterDelay to delay the transition if needed.

What alternative solutions did you explore? (Optional)

[roryabraham]

Kicked off an AdHoc build for a revert of https://github.com/Expensify/App/pull/40369 to see if that fixes this problem.

[mollfpr]

As mentioned in the @Krishna2323 proposal, didScreenTransitionEnd is bugging for iOS and probably added to avoid the animation starting while the transition is happening. Removing it from the check is to fix this issue, but I'm not sure the case for the check where is needed.

[kavimuru]

Two testers tried to reproduce. One wasn't able to while the other was able to.

https://github.com/Expensify/App/assets/43996225/f197959d-6766-4427-9201-ed19273d904f

https://github.com/Expensify/App/assets/43996225/d1dba7b6-3a04-45b6-bdc7-3670b4d39442

[francoisl]

Kicked off an AdHoc build for a revert of https://github.com/Expensify/App/pull/40369 to see if that fixes this problem.

@roryabraham did that AdHoc build fix the issue? Should we go ahead with a revert or with @Krishna2323's proposal in this case?

[thienlnam]

I was testing the adhoc, and it seemed to work fine after this revert

[thienlnam]

We're having the revert CPed