[$250] improve failureNotifier.yml to catch more failures

[blimpich]

Problem

This is a follow up to this issue. Its possible for breakages in main to go undetected still if issues created by previous breakages aren't closed out properly. See relevant slack thread.

Solution

Improve the workflow to catch these failures.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aebc028b3ff06629
• Upwork Job ID: 1781420349384224768
• Last Price Increase: 2024-04-19
• Automatic offers:
• jjcoffee | Reviewer | 0
• rayane-djouah | Contributor | 0

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot[bot]]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01aebc028b3ff06629

[melvin-bot[bot]]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[rayane-djouah]

Would like to work on this!

[rayane-djouah]

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1713554811796439

[blimpich]

I would like @jjcoffee and @rayane-djouah to work on this since they did the original ticket and have context.

[melvin-bot[bot]]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[blimpich]

@rayane-djouah @jjcoffee are you both available to work on this this week?

[jjcoffee]

I'm available. Do you need anything from me @rayane-djouah?

[rayane-djouah]

I was focusing on high priority issues, and was sick in the last two days. I will start working on it on Thursday.

[rayane-djouah]

Not overdue, PR on work

[rayane-djouah]

PR ready for review

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.69-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/41124

If no regressions arise, payment will be issued on 2024-05-09. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@jjcoffee / @rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@jjcoffee / @rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@jjcoffee / @rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@jjcoffee / @rayane-djouah] Determine if we should create a regression test for this bug.
• [ ] [@jjcoffee / @rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR MAY 09

• Fix: @rayane-djouah [$250, if no regressions] offer link
• PR Review: @jjcoffee [$250, if no regressions] offer link

[abekkala]

This isn't overdue - payment is set for tomorrow!

[abekkala]

@rayane-djouah and @jjcoffee payments sent and contracts ended - thank you!