App icon indicating copy to clipboard operation
App copied to clipboard

Deleting failed smartscan expense put workspace chat into weird state.

Open m-natarajan opened this issue 10 months ago • 1 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712855834212319

Action Performed:

  1. in Account 1, submit two expenses, and have one where smartscan fails.
  2. In account 2, approve the report with the two expenses (since one had smartscan fail, this should hold back the second one).
  3. In account 1, delete the expense where smartscan failed.
  4. This puts the workspace chat in a weird state where history cannot be accessed (in both accounts).

Expected Result:

No weird things should be observed

Actual Result:

This puts the workspace chat in a weird state where history cannot be accessed (in both accounts). We're calling openReport in an infinite loop.

Workaround:

unknonw

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/75deffdd-2b6b-4c7b-b717-ac0b48f5a176

View all open jobs on GitHub

m-natarajan avatar Apr 13 '24 13:04 m-natarajan

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Apr 13 '24 13:04 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b4f1c4133a2240c

melvin-bot[bot] avatar Apr 15 '24 07:04 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

melvin-bot[bot] avatar Apr 15 '24 07:04 melvin-bot[bot]

Not overdue, waiting on proposals

kadiealexander avatar Apr 18 '24 04:04 kadiealexander

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Apr 22 '24 16:04 melvin-bot[bot]

I have asked for a retest for this issue to see if it's still reproducible.

kadiealexander avatar Apr 23 '24 04:04 kadiealexander

@kadiealexander, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 26 '24 18:04 melvin-bot[bot]

@kadiealexander @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Apr 27 '24 18:04 melvin-bot[bot]

https://expensify.slack.com/archives/C9YU7BX5M/p1714368662879459

kadiealexander avatar Apr 29 '24 05:04 kadiealexander

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Apr 29 '24 16:04 melvin-bot[bot]

Unable to reproduce it, build 1.4.67.0, asking here -> https://expensify.slack.com/archives/C049HHMV9SM/p1714402638617059?thread_ts=1712855834.212319&cid=C049HHMV9SM

https://github.com/Expensify/App/assets/93399543/34d9db48-e0e9-4ab4-a327-5235036bffca

kbecciv avatar Apr 29 '24 17:04 kbecciv