App
App copied to clipboard
Expensify
DEV - Throws warning when starting desktop
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Dev Reproducible in staging?: dev Reproducible in production?: dev If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shubham1206agra Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712819917386169
Action Performed:
- Open desktop app in dev environment
Expected Result:
Opens without any issues
Actual Result:
Error message is thrown
Onyx DevTools - Error: ReferenceError: window is not defined [Electron] at DevTools.connectViaExtension (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:14:35) [Electron] at new DevTools (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:6:31) [Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:69:22) [Electron] at ./node_modules/react-native-onyx/dist/DevTools.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2717:1) [Electron] at webpack_require (/Users/prachiagrawal/code/App/desktop/dist/main.js:5411:42) [Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/Onyx.js?:37:36) [Electron] at ./node_modules/react-native-onyx/dist/Onyx.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2739:1) [Electron] at webpack_require (/Users/prachiagrawal/code/App/desktop/dist/main.js:5411:42) [Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/index.js?:7:32) [Electron] at ./node_modules/react-native-onyx/dist/index.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2816:1)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@pac-guerreiro , 👀 plz, this might be related to
- https://github.com/Expensify/react-native-onyx/pull/438
@mallenexpensify Yeah... this is one me 😅 I can take a look into it if you want!
Thanks for the quick reply, assigned to you. cc @marcaaron and @AndrewGable since you were the reviewers on the PR. Not assigning to either of ya, do so if you want.
@m-natarajan
I'm unable to reproduce this. Does the app crash to you? Are you running the app through npm run desktop?
@mallenexpensify, @pac-guerreiro Huh... This is 4 days overdue. Who can take care of this?
@pac-guerreiro , @m-natarajan is only responsible for creating issues, they don't monitor or (often) respond to pings once issues are created. Let's wait til the retest-weekly label triggers a retest then we'll see what next best steps are.
@pac-guerreiro @mallenexpensify Still able to repro on latest main.
@mallenexpensify
Thanks for the heads up! I didn't know about this, sorry 😅
@shubham1206agra
I was able to reproduce this and I'll create a PR with a fix for it 😄
My fix got merged and react-native-onyx was bumped to v2.0.34. We'll have to wait until we bump react-native-onyx version in the app
@mallenexpensify @pac-guerreiro this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
We'll have to wait until the we bump react-native-onyx version in the app
Thinking we're waiting on the above.
@mallenexpensify, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!
We'll have to wait until the we bump react-native-onyx version in the app
@mallenexpensify, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@mallenexpensify, @pac-guerreiro Still overdue 6 days?! Let's take care of this!
Bumped to weekly, per the comment above
We'll have to wait until the we bump react-native-onyx version in the app
QA team is not able to confirm if this issue is still reproducible during KI retests as it requires Development Desktop app. This issue will need to be retested internally
@mvtglobally
I can retest it once the PR I mentioned above gets merged! 😄
@mvtglobally @mallenexpensify
PR is now merged and the issue seems to be resolved! 😄
Thanks @pac-guerreiro , gonna close. Comment/reopen if you disagree or if the issue persists.
@mallenexpensify
Looks like the PR that fixed this got reverted in https://github.com/Expensify/App/pull/42725 😅
I'll keep you posted on any developments about this!
Meanwhile, this issue should show up again
@mallenexpensify
New PR is open - https://github.com/Expensify/App/pull/42772 😄