App icon indicating copy to clipboard operation
App copied to clipboard

[$250] IOU - Unable to add amount to scan failed IOU

Open kbecciv opened this issue 10 months ago • 6 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.62-2 Reproducible in staging?: y Reproducible in production?: y Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in.
  3. Go to the workspace policy expense chat
  4. Create a new scan request that will be fail
  5. Wait until the scan fails
  6. Edit the amount and save

Expected Result:

Able to add amount to scan failed IOU

Actual Result:

Unable to add amount to scan failed IOU

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/782c9d16-8f75-481d-985c-c74751013b66

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011e95672f893bbb72
  • Upwork Job ID: 1778436945764769792
  • Last Price Increase: 2024-04-11

kbecciv avatar Apr 11 '24 14:04 kbecciv

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Apr 11 '24 14:04 melvin-bot[bot]

We think that this bug might be related to #wave-collect - Release 1

kbecciv avatar Apr 11 '24 14:04 kbecciv

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

kbecciv avatar Apr 11 '24 14:04 kbecciv

Job added to Upwork: https://www.upwork.com/jobs/~011e95672f893bbb72

melvin-bot[bot] avatar Apr 11 '24 14:04 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

melvin-bot[bot] avatar Apr 11 '24 14:04 melvin-bot[bot]

I tried scanning an image with no text in it and it's still pending 40 hours later. Photo of a receipt is pending after 5 minutes.

james-tindal avatar Apr 13 '24 12:04 james-tindal

I tried adding an expense that fails on scan. However, after failing I am not seeing any option to add the amount to the expense, like shown in the video. Is the option to change the amount removed altogether or am I doing anything wrong reproducing the issue?

Video

https://github.com/Expensify/App/assets/54620116/619099f0-2f2a-482d-a63f-6154d791c7fa

sufyan-siddiqui avatar Apr 15 '24 19:04 sufyan-siddiqui

@bfitzexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Apr 16 '24 18:04 melvin-bot[bot]

When I "request money" in a workspace, it works fine. I can edit the amount and merchant after a failed scan. When I "track expense", the scan never finishes.

I can't reproduce this bug.

Update: After doing this a few times, I got one that repeatedly throws an error when I try to update the amount. This is the response from the server:

{
    "jsonCode": 500,
    "message": "500 Unhandled Exception",
    "onyxData": [],
    "requestID": "8756c7961c32dd73-LHR"
}

It's a server-side error.

james-tindal avatar Apr 16 '24 18:04 james-tindal

Thanks @james-tindal. Marking this as 'internal' for our team to work on given the nature of the problem

bfitzexpensify avatar Apr 16 '24 21:04 bfitzexpensify

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Apr 16 '24 21:04 melvin-bot[bot]

Commenting to satisfy melvin-bot

bfitzexpensify avatar Apr 16 '24 22:04 bfitzexpensify

@james-tindal just to confirm, was that in track expense or request money? @bfitzexpensify did you check out the logs for that requestID yet?

trjExpensify avatar Apr 18 '24 02:04 trjExpensify

It was in "request money". Looks like "request money" has been renamed to "submit expense" in staging. Whatever the UI ends up calling it, currently receipt scanning in selfDM / Your Space (track expense) never completes and never allows input to the Amount field. image

"Request money", now "submit expense", does complete the scan after a couple of minutes, and allows the user to input an Amount. Generally this works fine, but occasionally the server responds with repeated 500 errors on every input attempt. image

james-tindal avatar Apr 18 '24 10:04 james-tindal

Cool, thanks! These are internal links, so sorry in advance.

Logs for requestID: 8756c7961c32dd73-LHR

Caught unexpected exception: vector::_M_range_check: __n (which is 0) >= this->size() (which is 0) in command UpdateMoneyRequestAmountAndCurrency
Throwing exception with message: 'vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)' from N/A:0
Unhandled exception typename: std::out_of_range, command: UpdateMoneyRequestAmountAndCurrency

... which looks like @MonilBhavsar might have fixed yesterday with this PR, but maybe he can confirm. :)

trjExpensify avatar Apr 18 '24 14:04 trjExpensify

Yes, std::out_of_range exception is fixed now

MonilBhavsar avatar Apr 18 '24 14:04 MonilBhavsar

The scan that was showing the bug in my account has been working normally since yesterday.

james-tindal avatar Apr 19 '24 08:04 james-tindal

Issue is no longer reproduced!

https://github.com/Expensify/App/assets/93399543/91d1a161-8ae1-449f-9673-11c2164d28c0

kbecciv avatar Apr 19 '24 15:04 kbecciv