App
App copied to clipboard
Expensify
Add back the QR code download button
QR code download doesn't work anymore (as of today) since the new arch (Fabric PR) got merged.
TL;DR: react-native-view-shot does not support new arch yet.
It was decided here to hide the Download button for QR code in the meantime, to prevent users from encountering bugs and degrading user experience.
When the update 0.74 for react-native is available, we should:
- use it so
react-native-view-shotworks again as intended - Revert PR here and show back the Download button.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d1641a383b71483e
- Upwork Job ID: 1778781286743756800
- Last Price Increase: 2024-04-12
Proposal
Please re-state the problem that we are trying to solve in this issue.
QR code download using react-native-view-shot doesn't work after moving to the new arch.
What is the root cause of that problem?
The react-native-view-shot library has introduced the new architecture support in latest version, but we are still using 3.8.0. (https://github.com/gre/react-native-view-shot/pull/516)
Also, these changes in react-native need to be included.
What changes do you think we should make in order to solve the problem?
Add patch for the view-shot library with the changes for the new architecture or bump the version to 4.0.0-alpha.0.
Add patch for these changes in react-native.
Note: This is same as my proposal here.
@ShridharGoel thanks for your proposal but please refrain posting proposals in issues where the Help wanted label is not present.
Instead, post (like you did) in the issue where proposals are allowed, thank you!
Job added to Upwork: https://www.upwork.com/jobs/~01d1641a383b71483e
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to Contributor Plus for review of internal employee PR - @ahmedGaber93 (Internal)
Still waiting for RN 0.74 to be effective. Tracking PR here.
Still waiting for RN 0.74 PR to be available. Putting this as a monthly in the meantime.
Not overdue, Still hold on https://github.com/Expensify/App/issues/37374
PR https://github.com/Expensify/App/issues/37374 was merged, will take a look to add it back as soon as I can.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
PR didn't solve the issue, see https://github.com/Expensify/App/issues/49868#issuecomment-2381918469. We're going to wait for a new stable version.
I don't have a physical iOS device, I only have Android. I'm available to test if necessary. Thanks.
Still waiting for a stable version of react-native-viewshot v4.0.0 (see https://github.com/Expensify/App/issues/49868#issuecomment-2381918469).
Still waiting for a stable version of
react-native-viewshotv4.0.0(see #49868 (comment)).
Stable version is now available. As such, I've raised a new PR here.
@lakchote Can you please assign me as C+ reviewer in https://github.com/Expensify/App/pull/53757 ? Thank you.
Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@lakchote @fedirjh - heads up that I am OOO from 19th - 29th Dec. I'm happy to still be assigned and can sort out any payments when I'm back, but feel free to unassign me and reassign someone else if any urgent action is needed from B0.
@jliexpensify please process payment for @fedirjh for the C+ review.
If the timing is too short for you no worries, let me know and I'll reassign.
Easy, here's a Payment Summary:
- C+: @fedirjh $250 (to be paid via New.Dot)
@lakchote @fedirjh if there's a checklist, feel free to add that and ic an get to it when I'm back.
Otherwise this can be closed?
Otherwise this can be closed?
No checklist is needed for this one, we just re-enabled a feature.
