App
App copied to clipboard
Expensify
[$250] Chat - Contacts with no display name appear on top after searching for member during IOU flow
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.60-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A* Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com and log in with Expensifail account that has many contacts
- Go to FAB > Request money > Manual
- Enter amount
- Search for a member using search field > Select the member. (Important step)
- On confirmation page, close the RHP
- Go to FAB > Start chat
Expected Result:
The contact list in Step 6 will have the same list as Step 4
Actual Result:
There are contacts with blank display name on top of the list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/086224bb-2312-40e7-b52d-fbcdc8113b83
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d4e2c2f15597586e
- Upwork Job ID: 1776072508499795968
- Last Price Increase: 2024-04-05
- Automatic offers:
- rayane-djouah | Reviewer | 0
Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
This should be in #collect as it deals with Workspace Requests.
The actual bug itself is the fact that some emails show up without names:
Whereas they should always show up with bold names, even if it's just an email:
Job added to Upwork: https://www.upwork.com/jobs/~01d4e2c2f15597586e
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)
Weird. Anyone got an RCA on which PR has introduced this? I would think it must be a problem with the OptionSelector everywhere we use it.
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Proposal
Please re-state the problem that we are trying to solve in this issue.
Contacts with no display name appear on top of the list after searching for member during IOU flow.
What is the root cause of that problem?
The root problem seems to be in READ_COMMANDS.SEARCH_FOR_REPORTS api call inside searchForReports function.
After mentioned api request is called displayName for some users turns into ' ', which make them to be shown at the top of the contacts list with empty text.
What changes do you think we should make in order to solve the problem?
The SearchForReports API needs to be fixed in order to retrieve the correct data. Specifically, displayName field of the user’s personal data must always contain its display name instead of ' '.
Screenshots / recordings
Video recording of the search with/without READ_COMMANDS.SEARCH_FOR_REPORTS api call commented:
https://github.com/Expensify/App/assets/23176449/da1c4989-ddb6-411b-bf14-8484634d7abf
Screenshots of user personal details before/after calling mentioned API call:
Thank you for the proposal @VickyStash!
@jliexpensify, please remove the External label and add the Internal and Engineering labels. This is a back-end bug that needs to be fixed by an internal engineer.
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
Current assignee @rayane-djouah is eligible for the Internal assigner, not assigning anyone new.
unassigning myself as C+ review is not needed here. this need to be fixed from backend.
@jliexpensify I think this should be a hot pick issue; you can change it back to polish if you disagree.
@jliexpensify Since it seems to be a back-end issue, it should be fixed internally. So I guess an internal engineer should be assigned. Thank you!
Got it, so did you want to continue to be assigned this issue then @VickyStash?
@jliexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
@chiragsalian, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
oh odd, the code for this went live 2 weeks back. Closing the issue since it should be resolved now.
