App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Web - Group Conversation - There are redundant lines in mention popup when mention @...

Open lanitochka17 opened this issue 10 months ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.59-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Tap on the any group chat
  3. Typing @..
  4. Scroll down popup

Expected Result:

Not have redundant lines in mention popup when mention @..

Actual Result:

There are redundant lines in mention popup when mention @..

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5e7f57db-29c5-40b4-944c-4739e7be426d

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b5430fff43fbf9eb
  • Upwork Job ID: 1775667456719233024
  • Last Price Increase: 2024-04-10

lanitochka17 avatar Apr 03 '24 22:04 lanitochka17

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Apr 03 '24 22:04 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Apr 03 '24 22:04 github-actions[bot]

Production:

https://github.com/Expensify/App/assets/78819774/ad679100-37c1-4728-8a6c-95633148e746

lanitochka17 avatar Apr 03 '24 22:04 lanitochka17

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Apr 03 '24 22:04 lanitochka17

I can't reproduce this with my high traffic account, it's a minor display bug, and it seems to be account specific, so gonna demote to NAB

jasperhuangg avatar Apr 03 '24 23:04 jasperhuangg

Job added to Upwork: https://www.upwork.com/jobs/~01b5430fff43fbf9eb

melvin-bot[bot] avatar Apr 03 '24 23:04 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

melvin-bot[bot] avatar Apr 03 '24 23:04 melvin-bot[bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Apr 03 '24 23:04 melvin-bot[bot]

📣 @sea1375! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Apr 07 '24 02:04 melvin-bot[bot]

Contributor details My Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~01e06e26f8cd83d24f

judy-hopps-12345 avatar Apr 07 '24 02:04 judy-hopps-12345

### Proposal

Please re-state the problem that we are trying to solve in this issue. Web - Group Conversation - There are redundant lines in mention popup when mention @... #39564

What is the root cause of that problem? I have tested this problem carefully but it works correctly. I have attached the result.

https://github.com/Expensify/App/assets/67734399/965a8f64-b0cf-44c5-b421-930c3f662d32

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional) NA

judy-hopps-12345 avatar Apr 07 '24 02:04 judy-hopps-12345

@rushatgabhane - I believe we are waiting on you to review the proposals above! Can you pls take a look?

anmurali avatar Apr 09 '24 16:04 anmurali

There are no proposals. like @sea1375, I can't reproduce this issue either

rushatgabhane avatar Apr 09 '24 16:04 rushatgabhane

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Apr 10 '24 16:04 melvin-bot[bot]

@anmurali, @chiragsalian, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 12 '24 18:04 melvin-bot[bot]

waiting on proposals

rushatgabhane avatar Apr 13 '24 15:04 rushatgabhane

@anmurali, @chiragsalian, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 16 '24 18:04 melvin-bot[bot]

I can't reproduce either. Let's close it.

anmurali avatar Apr 17 '24 01:04 anmurali

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Apr 17 '24 01:04 MelvinBot