Expensify
[HOLD BE work] Workspace chat expense report show up in the LHN without a GBR or as unread
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712068571511789
Prerequisite Be on a collect plan where User A is approver and User B is an employee User A has priority mode set to #focus
Action Performed:
(also see reproducible steps below from @eVoloshchak )
- User B/employee submits expense
- User A opens app and observes either
- The report from user B doesn't show in LHN
- The report from user B is not bold and/or does not have 🟢 for Green Brick Road (GBR)
- Click on the report
Expected Result:
Report should show in LHN and/or GBR should show up in the LHN for the workspace chat
Actual Result:
Report doesn't show in LHN or GBR is not shown and chat is not bold to indicate it is unread very often, when I click on the workspace chat, then a GBR appears.
Seems like perhaps we aren't properly sending the hasOutstandingChildRequest field when a report is sent via instant submit
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [x] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010d8f311682125da6
- Upwork Job ID: 1779939910911811584
- Last Price Increase: 2024-06-06
Issue Owner
Current Issue Owner: @grgia
Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
I'm not an approver on a workspace myself, so I won't be able to reproduce this. Applying the retest-weekly label and will ping the #QA room in Slack (per SO)
Edit: posted in Slack!
Unable to reproduce
https://github.com/Expensify/App/assets/43996225/922761a4-b225-4f80-8189-a4f1c5795258
@kavimuru can you try testing with Instant Submit and doing Scan Receipt instead of manual.
@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
I can consistently reproduce this every day. How can I help troubleshoot?
⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.
Job added to Upwork: https://www.upwork.com/jobs/~010d8f311682125da6
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)
@johncschuster , snagging this from you cuz I'm working on documenting a process for issues that need reproduction. @eVoloshchak , can you see if you can reproduce plz? I create a job for $125 to provide reproduction steps, testing this out before I work on internally here.
Sounds good, @mallenexpensify! Just a heads up, it looks like @puneetlath can consistently reproduce this every day, so I think we need to get clear on what the difference is between Puneet's reproduction setup and @kavimuru's setup.
@eVoloshchak @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@eVoloshchak, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@eVoloshchak @mallenexpensify this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
I still experience this every day. This is a core part of the Collect approver experience. What can I do to help diagnose? Would it be helpful to get device logs?
@puneetlath is this the same or similar bug? I think my repro steps are
- Submit expense on collect policy
- As approver, observe the submitted expense doesn't show in LHN when in #focus mode
Submitted report
In approver view, the request doesn't show when in #focus mode
https://github.com/Expensify/App/assets/22508304/2daa61db-a7fb-43ed-882d-c38736af2d0f
Hmm, it could be similar, yes. What I consistently get is that the reports show up in the LHN, but they aren't bolded and they don't have the GBR.
Though I did just experience the same issue as you, where I got sent one but it's not showing up in my LHN at all.
Thanks @puneetlath , updated OP, title and price. Shared in #expensify-open-source too. Will try to prioritize this https://expensify.slack.com/archives/C01GTK53T8Q/p1714670946557159
Here's an example from today. The chat in the bottom of the LHN from Nick is his workspace chat, which is there because he sent a request. But it is neither showing as unread or with the GBR.
Once I click on it, the GBR arrives.