Expensify
WS Categories - A space gap is displayed for a moment on the list after category deletion
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4466254 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause - Internal Team
Action Performed:
Pre-requisite: the user must be logged in and have created a collect workspace
- Go to Workspace > Categories
- Select a category (check the box)
- Delete the category
- Verify that after deletion, there is a space gap displayed for a moment where the category was
Expected Result:
There should be no space gap displayed after category deletion
Actual Result:
A space gap is displayed for a moment after category deletion
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/ceed34b6-fea8-4ebe-ab1b-f9f2c42cce44
Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@JmillsExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
Job added to Upwork: https://www.upwork.com/jobs/~0140f5a4dbf368b480
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)
Proposal
Please re-state the problem that we are trying to solve in this issue.
WS Categories - A space gap is displayed for a moment on the list after category deletion
What is the root cause of that problem?
In the file, WorkspaceCategoriesPage.tsx, I think when we delete a category list then it takes time to get updated.
What changes do you think we should make in order to solve the problem?
I think we can add this code,
const updatedList = categoryList.filter(c => c.name !== deletedCategoryName)
setCategoryList(updatedList)
what it will do is - When deleting a category, immediately update the categoryList state by filtering out the deleted category. This will remove it from the list optimistically before the API request finishes.
What alternative solutions did you explore? (Optional)
N/A
Proposal
Please re-state the problem that we are trying to solve in this issue.
WS Categories - A space gap is displayed for a moment on the list after category deletion
What is the root cause of that problem?
In TableListItem.tsx, containerStyle of BaseListItem has been added with styles.mb3 3 weeks ago.
It's happening this bug that shows a gap space of mb3 while deleting a category.
What changes do you think we should make in order to solve the problem?
We can move this mb3 style to pressableStyle instead of containerStyle
What alternative solutions did you explore? (Optional)
n/a
📣 @solar-dev23! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~018b3dcfc2c45fda08
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Not reproducible, probably fixed by https://github.com/Expensify/App/pull/39226
https://github.com/Expensify/App/assets/59907218/3cdfbc18-414b-49be-8162-b5c483d5116c
Not reproducible, probably fixed by #39226
Screen.Recording.2024-04-12.at.11.01.36.PM.mov
This is the correct PR )
@JmillsExpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@JmillsExpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸