Fix For Spacing Around Toggle Buttons

[brandonhenry]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38370 PROPOSAL: https://github.com/Expensify/App/issues/38370#issuecomment-2000241766

Tests

1. Open app and switch the language to spanish
2. Go to any "collect" workspace
3. Click categories >settings

• [x] Verify that no errors appear in the JS console

Offline tests

1. Open the Expensify app and switch the language to Spanish.
2. Navigate to any "collect" workspace.
3. Click on the categories option and then select settings.
4. Disable the internet connection on the device.
5. Repeat steps 1-6 for all supported platforms:
   • Android: Native
   • Android: mWeb Chrome
   • iOS: Native
   • iOS: mWeb Safari
   • MacOS: Chrome / Safari
   • MacOS: Desktop

• [x] Verify that no errors appear in the JS console
• [ ] Verify that the app displays the appropriate offline message or placeholder UI.
• [ ] Verify that the UI elements are properly aligned and the design meets the requirements.

QA Steps

1. Open the Expensify app and switch the language to Spanish.
2. Navigate to any "collect" workspace.
3. Click on the categories option and then select settings.
4. Repeat steps 1-3 for all supported platforms:
   • Android: Native
   • Android: mWeb Chrome
   • iOS: Native
   • iOS: mWeb Safari
   • MacOS: Chrome / Safari
   • MacOS: Desktop

• [x] Verify that no errors appear in the JS console
• [ ] Verify that the UI elements are properly aligned and the design meets the requirements.

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Video

https://github.com/Expensify/App/assets/15656774/53a6544f-0eef-43a8-88a1-ed720344ba46

https://github.com/Expensify/App/assets/15656774/ad1c4ec7-5075-48ab-88ce-566eca616149

[brandonhenry]

might be an easier change than I thought, testing @parasharrajat

[parasharrajat]

@brandonhenry let's please speed up the work here. This is not a big issue to hold for long. We would like it to be closed asap.

[parasharrajat]

Please remove [38370] from the title.

[melvin-bot[bot]]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[brandonhenry]

@parasharrajat i agree, felt like too much refactor for something small. going with my original proposal

[parasharrajat]

@brandonhenry QA tests and Offline tests all are mandatory.

[parasharrajat]

@brandonhenry we need screenshots on all platforms. Can you please update those? Also, I don't think your solution worked on ios Native.

[brandonhenry]

for sure. recent main pull in has broken my ios/android build so resolving

[brandonhenry]

update: got my android building. looks like i had to remove the old build from the simulator first due to some odd error

[brandonhenry]

@parasharrajat adjusted fix. We need to also include flexShrink to complete fix for react native as well. This article explains why in depth.

Let me know if you have any concerns. Getting updated screens now

[parasharrajat]

@brandonhenry I am still waiting on other things. Please ping me once done.

[brandonhenry]

yeah sure. all done just trying to fix my ios build errors for the last two screens @parasharrajat

[brandonhenry]

@parasharrajat i have completed all tests and added all necessary screenshots. back over to you

[parasharrajat]

Screenshots

:black_square_button: iOS / native

https://github.com/Expensify/App/assets/24370807/17b53497-1681-4d39-bb72-8791af3e4ed8

:black_square_button: iOS / Safari

https://github.com/Expensify/App/assets/24370807/993a5fc0-1514-46a3-a2cf-fd5d55ab1ef4

:black_square_button: MacOS / Desktop

https://github.com/Expensify/App/assets/24370807/3399d6aa-6695-4c23-b9a7-01ad950a0221

:black_square_button: MacOS / Chrome

https://github.com/Expensify/App/assets/24370807/46d18c02-7478-41c0-94b5-63cffe8ce435

:black_square_button: Android / Chrome

https://github.com/Expensify/App/assets/24370807/656117d8-8dd3-443c-97ee-94a7955ed198

:black_square_button: Android / native

https://github.com/Expensify/App/assets/24370807/645fa512-98c4-4e93-a3d5-e6be45d8e4a9

[parasharrajat]

@tylerkaraszewski Ready for review.

[parasharrajat]

Bump @tylerkaraszewski

[tylerkaraszewski]

Looks like the linter is failing here. Can you fix that?

[parasharrajat]

@brandonhenry could you please run prettier npm script?

[brandonhenry]

this is all good @tylerkaraszewski @parasharrajat

[parasharrajat]

@tylerkaraszewski Ready for merge.

[brandonhenry]

@tylerkaraszewski let me know if you can get to this one today, thanks!

[brandonhenry]

@tylerkaraszewski any updates? Would like to get this merged ASAP

[OSBotify]

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅