HIGH: [Performance] [$500] Reliably unsubscribe from isTyping events when leaving rooms

[quinthar]

Problem:

When you join a room, you subscribe to various Pusher channels that should only be active while in that room. However, when you leave the room, sometimes it doesn't unsubscribe you from the channels. This "leak" will gradually slow down the app. But particularly concerning is that it will cause you to receive Pusher events that do not relate to the current room (such as "istyping" events in rooms you aren't looking at), and thus drag down your performance.

Solution:

Reliably unsubscribe from the room's Pusher channel when leaving by any method. There is a theory that we do this when leaving a room to switch to another, but perhaps not when leaving the room to go to a non-room page (eg, Settings).

See: https://expensify.slack.com/archives/C049HHMV9SM/p1711131919203929

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a36c87d591ea59b
• Upwork Job ID: 1773645194916745216
• Last Price Increase: 2024-03-29