[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] No pop-over after bulk-selecting rates and trying to disable/delete them

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56.0 Reproducible in staging?: y Reproducible in production?: n Issue found when executing PR: https://github.com/Expensify/App/pull/38237 Issue reported by: Applause - Internal Team

Action Performed:

precondition: user created a collect policy in OD

1. Go to https://staging.new.expensify.com/ and log in as the admin of the collect policy
2. Navigate to the workspace settings > More features
3. Enable Distance rates
4. Open Distance rates
5. Tap bulk-select
6. In the drop-down select Disable rates"/ "Delete rates"
7. On the pop-over tap “Got it”
8. Delete one distance rate
9. Tap bulk select > Disable rates/Delete rates

Expected Result:

The same pop-over is displayed in step 6 and 9 notifying that at least one distance rate should be enabled

Actual Result:

The error message "There must be at least one enabled distance rate' is displayed instead of the pop-over the second time trying to disable the distance rates, the error on the distance rate edit screen is shown.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/3d30c29f-e101-4340-a0d4-414f932e752c

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da91acddaa976701
• Upwork Job ID: 1772188427745120256
• Last Price Increase: 2024-03-25

Issue Owner

Current Issue Owner: @sonialiap

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot[bot]]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01da91acddaa976701

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot[bot]]

Upwork job price has been updated to $250

[mountiny]

Assigning Michal and taking over since its related to the wave-collect, its not a blocker since this feature is not out there for clients yet.

[MrMuzyk]

This issue was happening on all platforms as it was related to JS logic

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.57-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/38929

If no regressions arise, payment will be issued on 2024-04-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)
• @MrMuzyk does not require payment (Contractor)

[melvin-bot[bot]]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

$250 to @hoangzinh unless you have reviewed the offending PR too?

[hoangzinh]

oh nope, the offending PR is not mine. Hehe

[sonialiap]

@hoangzinh $250 - offer sent

[hoangzinh]

Accepted. Thanks @sonialiap

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)
• Contributor: @MrMuzyk is from an agency-contributor and not due payment

BugZero Checklist (@sonialiap)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1772188427745120256/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[sonialiap]

Payment completed ✔️