Fix/37847 - Show the tags in the first policyTagLists

[Tony-MK]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/37847 $ https://github.com/Expensify/App/issues/38683 PROPOSAL: https://github.com/Expensify/App/issues/37847#issuecomment-1982018079

Tests

1. Go to Collect Workspace.
2. Click the Tag button on the menu.
3. Verify no multi-level tags are present.
4. Click on a tag.
5. Verify the :/ string is present.
6. Click to edit tag.
7. Verify the :/ string is present.
8. Save the tag.

• [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Go to Collect Workspace.
2. Click the Tag button on the menu.
3. Verify no multi-level tags are present.
4. Click on a tag.
5. Verify the :/ string is present.
6. Click to edit tag.
7. Verify the :/ string is present.
8. Save the tag.

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot[bot]]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[allroundexperts]

@Tony-MK Can you please add test steps?

[allroundexperts]

@Tony-MK I can still see different tag lists being displayed even after this change.

[Tony-MK]

@Tony-MK I can still see different tag lists being displayed even after this change.

Could you show me a screenshot?

[luacmartins]

@Tony-MK @allroundexperts any updates here?

[luacmartins]

Added https://github.com/Expensify/App/issues/38683 to the list of fixed issues here

[Tony-MK]

@Tony-MK I can still see different tag lists being displayed even after this change.

Could you show me a screenshot?

@allroundexperts, Could you show me an example of this happening?

I tried checking again but it worked fine.

[Tony-MK]

@Tony-MK @allroundexperts any updates here?

Waiting for @allroundexperts response's.

[allroundexperts]

{
    "Region": {
        "name": "Region",
        "orderWeight": 1,
        "tags": {
            "North+test": {
                "enabled": true,
                "name": "North+test"
            },
            "South": {
                "enabled": true,
                "name": "South"
            }
        }
    },
    "State": {
        "name": "State",
        "orderWeight": 0,
        "required": true,
        "tags": {
            "California": {
                "enabled": true,
                "name": "California"
            },
            "North+test": {
                "enabled": false,
                "name": "North+test"
            }
        }
    }
}

@Tony-MK As you can see from the data stored in onyx, we want to show only one of the Taglist. Currently, we do not support multi tag lists.

[luacmartins]

@Tony-MK did the comment above help?

[Tony-MK]

@Tony-MK As you can see from the data stored in onyx, we want to show only one of the Taglist. Currently, we do not support multi tag lists.

Hey @luacmartins and @allroundexperts,

According to the bug description, https://github.com/Expensify/App/issues/37847#issuecomment-2004770860 and https://github.com/Expensify/App/issues/37847#issuecomment-1982183268, I think we are supposed to hide the Parent: Child tags and display the root level for now.

Right?

[luacmartins]

Yes, that's correct!

[luacmartins]

@Tony-MK we also have conflicts

[Tony-MK]

Hey @luacmartins and @allroundexperts, solved the merge conflicts.

It's ready to be merged. 😄

[luacmartins]

@Tony-MK conflicts again. Bump @allroundexperts for review

[Tony-MK]

Gentle bump to @allroundexperts for review?

[luacmartins]

Reassigning as per https://expensify.slack.com/archives/C02NK2DQWUX/p1711707769397279

[hoangzinh]

Hi @luacmartins come from those comments https://github.com/Expensify/App/issues/37847#issuecomment-2004770860 and https://github.com/Expensify/App/issues/37847#issuecomment-1982183268, just wanna confirm again, let's say we have tags:

• Tag1
• Tag2: ChildTag2

Then on the tags page, we would like to display as:

Option 1:

• Tag1

Option 2:

• Tag1
• Tag2

Which one is correct? Thanks

[hoangzinh]

@Tony-MK can you update the PR title with more details? Current PR title:

• It's hard to find PR later
• When receiving Github notifications, we don't know what is it until click to view details

[luacmartins]

@JmillsExpensify @trjExpensify which one is the correct behavior for simplified collect? https://github.com/Expensify/App/pull/38759#issuecomment-2027390286

[luacmartins]

Waiting on @JmillsExpensify or @trjExpensify for confirmation

[trjExpensify]

Tag1 Tag2: ChildTag2

To confirm, are "Tag 1" and "Tag 2" different levels of tags (i.e customers and departments), or different values in the one level of tags (i.e customer 1, customer 2)?

[hoangzinh]

different values in the one level of tags (i.e customer 1, customer 2)

It's this one @trjExpensify. To be more specific, this is the tags page in OD

[trjExpensify]

Okay, so that's showing just the one single level of tags. That isn't multi-level tags or dependent tags, so why wouldn't those show all of the single level tag values in the NewDot tags page? So like this:

Tag1 Tag2: ChildTag2

Multiple-levels of tags looks like this for reference:

https://github.com/Expensify/App/assets/16232057/ef7bb195-a47d-4fc1-a4ba-97e80276da28

[luacmartins]

@trjExpensify thanks for clarifying that. From your OldDot example of multi-level tags, what should be shown to the user? Right now we only support a single tagList, so we'd only show the tags in the Projects list, I believe. Is that right?

[trjExpensify]

so we'd only show the tags in the Projects list, I believe. Is that right?

Correct, we're only supporting one level until the QBO project supports multiple levels. :)

[luacmartins]

@Tony-MK cool, so based on Tom's previous comment and the video above, we'd show only the tags in the Projects tagList seen at 0:02 in the video, i.e. 000 - Default, Description, J&P Cycles

[hoangzinh]

@Tony-MK Moreover, for parent-child tags, we would like to display them as well, not hide them, as per https://github.com/Expensify/App/pull/38759#issuecomment-2032207968. But we also need to fix the current display issue in https://github.com/Expensify/App/issues/37847

[luacmartins]

Yes

[Tony-MK]

@Tony-MK cool, so based on Tom's previous comment and the video above, we'd show only the tags in the Projects tagList seen at 0:02 in the video, i.e. 000 - Default, Description, J&P Cycles

@luacmartins, are we only showing the tagList from the first parent tag ie. Projects or the rest of the tags as well.