App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

New chat page list refactor 2

Open lukemorawski opened this issue 1 year ago • 2 comments

Details

This PR refactors the NewChatPage to use new component. A new param has been added to to allow it to display a component on the right hand side of each list item. This param allows to pass a react node or a function that will render a component.

Fixed Issues

$ https://github.com/Expensify/App/issues/20354 PROPOSAL: no proposal

Tests

  • [ ] same as QA
  • [ ] Verify that no errors appear in the JS console

Offline tests

same as QA

QA Steps

  • [ ] tap FAB on main screen and choose "Start Chat"
  • [ ] tap on a contact to start a chat
  • [ ] OR tap split on couple of contacts and start a chat
  • [ ] OR search for contacts and tap on contact to start a chat
  • [ ] OR search for contacts and tap split on couple of contact to start a chat
  • [ ] observe if page behaves exactly the same as on staging
  • [ ] Verify that no errors appear in the JS console

PR Author Checklist

  • [x] I linked the correct issue in the ### Fixed Issues section above
  • [x] I wrote clear testing steps that cover the changes made in this PR
    • [x] I added steps for local testing in the Tests section
    • [x] I added steps for the expected offline behavior in the Offline steps section
    • [x] I added steps for Staging and/or Production testing in the QA steps section
    • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I ran the tests on all platforms & verified they passed on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [x] I followed proper code patterns (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I followed the guidelines as stated in the Review Guidelines
  • [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/134388952/422a83cf-1f74-4898-81ad-bfc65984e020

Android: mWeb Chrome

https://github.com/Expensify/App/assets/134388952/3a46d724-8c42-4abb-aab3-cf04200766ed

iOS: Native

https://github.com/Expensify/App/assets/134388952/eee5212c-bb7d-4459-939a-224e1aeee15b

iOS: mWeb Safari

https://github.com/Expensify/App/assets/134388952/fd6173d9-34da-4fcc-963e-736b02672aca

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/134388952/2831c6c5-bc28-4a6f-bf3e-9c7362ffc581

MacOS: Desktop

https://github.com/Expensify/App/assets/134388952/f7d4cab9-07dc-438c-8967-874e357a763f

lukemorawski avatar Mar 19 '24 16:03 lukemorawski

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Mar 19 '24 16:03 melvin-bot[bot]

Reviewer Checklist

  • [x] I have verified the author checklist is complete (all boxes are checked off).
  • [x] I verified the correct issue is linked in the ### Fixed Issues section above
  • [x] I verified testing steps are clear and they cover the changes made in this PR
    • [x] I verified the steps for local testing are in the Tests section
    • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
    • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I checked that screenshots or videos are included for tests on all platforms
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I verified tests pass on all platforms & I tested again on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • [x] I verified proper code patterns were followed (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
  • [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] If a new component is created I verified that:
    • [x] A similar component doesn't exist in the codebase
    • [x] All props are defined accurately and each prop has a /** comment above it */
    • [x] The file is named correctly
    • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • [x] The only data being stored in the state is data necessary for rendering and nothing else
    • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • [x] All JSX used for rendering exists in the render method
    • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome image
iOS: Native
iOS: mWeb Safari image

https://github.com/Expensify/App/assets/29673073/c5b98604-662f-4040-8343-2c99244fddd6

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/29673073/d3a9284e-1f8a-480c-8e21-53d01f1ef773

https://github.com/Expensify/App/assets/29673073/4d211af7-7924-4226-8872-8dae672d37bc

MacOS: Desktop image

rushatgabhane avatar Mar 22 '24 18:03 rushatgabhane

Looks like 537 files changed?

shawnborton avatar Apr 03 '24 19:04 shawnborton

Expected: last contact is selected

Just to clarify, when you say "last contact" do you mean the list loops around to the bottom of the list or that it stops at the top of the list. Cause I think the latter should happen. Perhaps @Expensify/design has any thoughts though.

dubielzyk-expensify avatar Apr 04 '24 02:04 dubielzyk-expensify

mean the list loops around to the bottom of the list

yes i mean that it should loop around and the last contact should be highlighted.

this is how it works on staging so i doubt we should change that here

rushatgabhane avatar Apr 04 '24 03:04 rushatgabhane

Just to clarify, when you say "last contact" do you mean the list loops around to the bottom of the list or that it stops at the top of the list. Cause I think the latter should happen. Perhaps @Expensify/design has any thoughts though.

yes i mean that it should loop around and the last contact should be highlighted. this is how it works on staging so i doubt we should change that here

Dang it's about to get spicy up in here because I also think it should just stop at the top of the list. 🌶️ 😅 I really don't see the benefit in looping to the bottom of the list. (But maybe I'm missing something!)

Basically is this error happening because we only load 500 items at a time? Like if you had 1,000 contacts, we'd load 500 and then once you scrolled to the bottom we'd load 500 more, right? So if you try to loop around to the "last" contact, we haven't actually loaded it yet which is causing this error?

dannymcclain avatar Apr 04 '24 13:04 dannymcclain

I really don't see the benefit in looping to the bottom of the list. (But maybe I'm missing something!)

Agree with you. Think it should just stop at the top

dubielzyk-expensify avatar Apr 04 '24 23:04 dubielzyk-expensify

@rushatgabhane sorry closed the PR, 'cause dealing with all the conflicts was just to much. I've reset the branch and cherry picked the changes from a backup. Reopened again.

lukemorawski avatar Apr 05 '24 17:04 lukemorawski

@rushatgabhane can you review this quickly please. I would like to close this PR ASAP.

lukemorawski avatar Apr 12 '24 11:04 lukemorawski

I had approved this earlier, @cristipaval all yours

rushatgabhane avatar Apr 13 '24 20:04 rushatgabhane

DANG! conflicts, could you please resolve them, @lukemorawski

cristipaval avatar Apr 15 '24 12:04 cristipaval

@cristipaval fixed them conflicts!

lukemorawski avatar Apr 15 '24 14:04 lukemorawski

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify avatar Apr 15 '24 15:04 OSBotify

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.63-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Apr 18 '24 04:04 OSBotify

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Apr 22 '24 14:04 OSBotify