[HOLD for payment 2024-04-05] [Simplified Collect][Workflows] Report preview buttons do not reflect selected Workflow

[luacmartins]

After Workflows implementation, we need to update the report preview buttons to reflect the selected workflow, i.e. this section of the HL doc:

Update the various conditionals to reflect this

cc @lakchote

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lakchote]

Updates are still happening, and Carlos will work on this today 🙏

[abekkala]

Any update on this one?

[luacmartins]

Lucien pushed some commits to the PR, I'll review and test today!

[melvin-bot[bot]]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

@laurenreidexpensify I'm ooo untli April 08 - I'll be taking back any Open issues when I return

---

CURRENT STATUS:

@luacmartins is reviewing some work that was completed by @lakchote. PR Review is being done by @rushatgabhane Payments for Rushat are done via NEWDOT

[luacmartins]

@rushatgabhane is reviewing that PR

[luacmartins]

PR merged

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.57-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/38253

If no regressions arise, payment will be issued on 2024-04-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@rushatgabhane] Determine if we should create a regression test for this bug.
• [ ] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@abekkala / @laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot

BugZero Checklist (@abekkala)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[laurenreidexpensify]

Payment Summary:

• @rushatgabhane requires payment through NewDot Manual Requests $250

[rushatgabhane]

@laurenreidexpensify i was wondering if the payment would be $500 because this issue was created before change in base price

[laurenreidexpensify]

Yip that's valid @rushatgabhane - update:

Payment Summary:

@rushatgabhane requires payment through NewDot Manual Requests $500

[laurenreidexpensify]

@rushatgabhane bump for regression test confirmation

@abekkala am unassigning myself now that you back from OOO :)

[rushatgabhane]

WIP ⚠️

1. The PR that introduced the bug has been identified. Link to the PR:

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

4. Determine if we should create a regression test for this bug.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

[JmillsExpensify]

$500 approved for @rushatgabhane