App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceTaxesSettingsPage

Open luacmartins opened this issue 1 year ago • 14 comments

Implement this section of the Simplified Collect: Taxes doc

cc @kosmydel @filip-solecki

luacmartins avatar Mar 05 '24 20:03 luacmartins

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Mar 05 '24 20:03 melvin-bot[bot]

Hi! I am Filip from SWM and I'd like to work on this issue!

filip-solecki avatar Mar 08 '24 19:03 filip-solecki

@anmurali, @luacmartins, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Mar 12 '24 19:03 melvin-bot[bot]

on hold

luacmartins avatar Mar 13 '24 05:03 luacmartins

No longer on hold. I would be delighted if I could continue to accompany @filip-solecki on this issue

DylanDylann avatar Mar 14 '24 06:03 DylanDylann

@luacmartins Also help to remove the hold label from the title of the issue

@filip-solecki It seems these features are our priority. Let's start making the PR for this one

DylanDylann avatar Mar 15 '24 07:03 DylanDylann

I am preparing PR right now

filip-solecki avatar Mar 15 '24 07:03 filip-solecki

PR is going to be merged today

mountiny avatar Mar 18 '24 15:03 mountiny

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Mar 19 '24 23:03 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.54-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/38373

If no regressions arise, payment will be issued on 2024-03-26. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @DylanDylann requires payment (Needs manual offer from BZ)
  • @filip-solecki does not require payment (Contractor)

melvin-bot[bot] avatar Mar 19 '24 23:03 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Mar 19 '24 23:03 melvin-bot[bot]

@luacmartins @mountiny We handled 4 issues in this PR that make PR become bigger. I want to ask about how we process payments here

cc @anmurali

DylanDylann avatar Mar 29 '24 03:03 DylanDylann

Thanks for reaching out @DylanDylann! We'd still pay for a single PR review, since that's what was done here. While I understand that not all issues and PRs are made equal, and some are bigger or more complex than others, I still think that the compensation is fair in this situation.

luacmartins avatar Mar 29 '24 14:03 luacmartins

@luacmartins Thank you for your response. I am happy with your decision. This is a similar case that we also should consolidate into an issue

cc @puneetlath

DylanDylann avatar Mar 30 '24 17:03 DylanDylann

Job added to Upwork: https://www.upwork.com/jobs/~0147321941f3740121

melvin-bot[bot] avatar Apr 02 '24 22:04 melvin-bot[bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Apr 02 '24 22:04 melvin-bot[bot]

I believe this is $500 to @DylanDylann and we can close it

mountiny avatar Apr 02 '24 22:04 mountiny

Bump for payment

luacmartins avatar Apr 03 '24 15:04 luacmartins

Waiting on payment @anmurali

luacmartins avatar Apr 08 '24 16:04 luacmartins

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Apr 08 '24 18:04 melvin-bot[bot]

Offer is here

anmurali avatar Apr 09 '24 16:04 anmurali

@anmurali Accepted offer. Thanks

DylanDylann avatar Apr 12 '24 08:04 DylanDylann

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 12 '24 18:04 melvin-bot[bot]

Seems like we're all done here? @DylanDylann

luacmartins avatar Apr 14 '24 17:04 luacmartins

@luacmartins I accepted the offer. Waiting for BZ pay the offer

DylanDylann avatar Apr 15 '24 14:04 DylanDylann

Thanks for the update. Just waiting on @anmurali

luacmartins avatar Apr 15 '24 16:04 luacmartins

@anmurali, @luacmartins, @mountiny, @DylanDylann, @filip-solecki Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Apr 16 '24 18:04 melvin-bot[bot]

@DylanDylann has been paid.

anmurali avatar Apr 17 '24 01:04 anmurali