Expensify
[$500] Workspace - System message for workspace description edit shows from "" to "x"
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.42-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- Navigate to staging.new.expensify.com
- Create a new workspace.
- Go to workspace profile.
- Click Add description.
- Add a description and save it.
- Go to #admin room.
Expected Result:
The system message shows <updated the description of this workspace to "m">.
Actual Result:
The system message shows <updated the description of this workspace from "" to "x">.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/6b76c38c-801f-43a5-8779-d4ad34a9e7f3
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01890415a5997d6fe7
- Upwork Job ID: 1772400631077556224
- Last Price Increase: 2024-03-25
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
We think that this bug might be related #wave5-free-submitters CC @dylanexpensify
We should fix this, but I'm removing the blocker label as it shouldn't block the release 👍
Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Why would we expect this when the description was blank?:
The system message shows <updated the description of this workspace to "m">.
@Julesssss, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Why would we expect this when the description was blank?:
Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?
Oh right. Good point. @kbecciv any other issue here we're missing, or can we close?
Friendly bump @kbecciv
@MitchExpensify Reopening the issue. Previously, we had an empty workspace description, but now there is a default workspace description (due to a new feature). However, the issue remains unresolved. Could you please advise whether it's preferable to open a new issue or to keep this one open as it is?
https://github.com/Expensify/App/assets/93399543/b2831c59-489b-4fa3-94a5-7c1c91201241
Yeah lets solve that here, good catch. Can you please update the OP accordingly? Thanks
Job added to Upwork: https://www.upwork.com/jobs/~01890415a5997d6fe7
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)
Seems like it is a BE issue. the update description request returns the current format as a new report action in the response
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - System message for workspace description edit shows from "" to "x"
What is the root cause of that problem?
When create workspace the policy description is empty and the current description has set to default description.
https://github.com/Expensify/App/blob/b25eb15b7122d093c60bf77b8c363187903f1248/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx#L29-L40
But when save new description we submit the current description with empty value while policy.description is undefined
https://github.com/Expensify/App/blob/b25eb15b7122d093c60bf77b8c363187903f1248/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx#L62
What changes do you think we should make in order to solve the problem?
While call function updateWorkspaceDescription at this line instead of submit current description is empty string if policy.description is undefined we should get the default description
What alternative solutions did you explore? (Optional)
@MitchExpensify this seems pretty low priority. Any preference for how we get this on the roadmap? I'll probably unassign once we've figured that out
Triggered auto assignment to Contributor Plus for review of internal employee PR - @hungvu193 (Internal)
No bites yet
@trjExpensify do we ever apply hot picks label to polish?
Yep, you can add the Hot picks label and move it into the Hot picks section of the project board so anyone browsing it can see it in that column. Once it's picked up, remove the label and move it back into Polish. 👍
This issue has not been updated in over 15 days. @chiragsalian, @MitchExpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Why did you move this back, @MitchExpensify? @chiragsalian put up a PR here: https://github.com/Expensify/Web-Expensify/pull/41774
Actually im just going to close out this issue since its done. Feel free to reopen if something is missing.