[ON HOLD #34610] [$500] Distance - Duplicate waypoints message does not instantly show up in distance request editor

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.41-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to workspace chat.
2. Go to + > Request money > Distance.
3. Enter A-B-A waypoints.
4. Reorder the waypoints by dragging so that it becomes A-A-B.
5. Note that error message for duplicate waypoints instantly shows up.
6. Change the distance back to A-B-A.
7. Proceed to confirmation page.
8. Click Distance.
9. Reorder the waypoints by dragging so that it becomes A-A-B.
10. Note that error message for duplicate waypoints instantly shows up.
11. Create the distance request with A-B-A waypoints.
12. Go to request details page.
13. Click Distance.
14. Reorder the waypoints by dragging so that it becomes A-A-B.

Expected Result:

The error message for duplicate waypoints will instantly show up.

Actual Result:

The error message for duplicate waypoints does not instantly show up. It only shows up after user attempts to save the duplicate waypoints.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/bcc27658-2a81-406a-88ec-03e39c76df46

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b6febd25fc272874
• Upwork Job ID: 1757796016628969472
• Last Price Increase: 2024-04-10

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b6febd25fc272874

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related #wave5-free-submitters CC @dylanexpensify

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing a Distance request, the duplicate waypoints error is not shown immediately.

What is the root cause of that problem?

When implementing this immediate error display, it was added only for the creation flow: https://github.com/Expensify/App/pull/32999, and the edit flow was missed.

What changes do you think we should make in order to solve the problem?

We need to add the same changes (made in https://github.com/Expensify/App/pull/32999 to IOURequestStepDistance) to the DistanceRequest/index.js, which is used on the edit flow.

As a side note, we should also add the !isEditingRequest as a third param here to merge the correct collection (non-draft transactions for the Edit flow) when updating the waypoints:

Transaction.updateWaypoints(transactionID, newWaypoints, !isEditingRequest)

https://github.com/Expensify/App/blob/6ed3706f7e69b330b7519dfd1e70864377bbab37/src/components/DistanceRequest/index.js#L203-L205

What alternative solutions did you explore? (Optional)

[s77rt]

I think DistanceRequest should / will be removed in https://github.com/Expensify/App/issues/34610

@zanyrenney Can you please put this on hold for https://github.com/Expensify/App/issues/34610

[zanyrenney]

DONE, thanks!

[zanyrenney]

This is on HOLD. so Not a daily priority just now.

[zanyrenney]

Not overdue, on hold.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still on hold

[s77rt]

Still on hold

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

ON HOLD

[s77rt]

On hold

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still on hold

[zanyrenney]

Still on hold.

[zanyrenney]

Going to move this to weekly, as it's been on hold a while.

[zanyrenney]

@s77rt feel free to DM me if you disagree / when you think we should be re-prioritising this.

[s77rt]

Weekly sounds good

[zanyrenney]

thank you @s77rt

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still on hold

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

It looks like the other issue is closed but not clear why. Gonna wait for the next overdue label till things are cleared up

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

It has now been reopened:

[zanyrenney]

distance being worked on in VIPVSB. https://expensify.slack.com/archives/C0671JDRKQW/p1710872125301479

adding to that project.