App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Weird push notification when invited to a room with a bunch of members

Open m-natarajan opened this issue 1 year ago โ€ข 3 comments

If you havenโ€™t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.38-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @jamesdeanexpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707336379216449

Action Performed:

  1. create a room
  2. Invite a bunch of members to the room
  3. Observe the push notification as one of the invited member

Expected Result:

Should show the invited members list

Actual Result:

mobile push notification doesn't make sense. we should update the bottom line to "invited you and [NUMBER] others"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

iPhone

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018a2b3f9aac2a663b
  • Upwork Job ID: 1755356945680076800
  • Last Price Increase: 2024-02-07

m-natarajan avatar Feb 07 '24 22:02 m-natarajan

Job added to Upwork: https://www.upwork.com/jobs/~018a2b3f9aac2a663b

melvin-bot[bot] avatar Feb 07 '24 22:02 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

melvin-bot[bot] avatar Feb 07 '24 22:02 melvin-bot[bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Feb 07 '24 22:02 melvin-bot[bot]

Is this BE?

jeremy-croff avatar Feb 08 '24 01:02 jeremy-croff

This issue relates to the notification system. So I think It should be handled on the BE side Send this message to get new eye from internal engineer

๐ŸŽ€ ๐Ÿ‘€ ๐ŸŽ€ C+ reviewed

DylanDylann avatar Feb 12 '24 15:02 DylanDylann

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Feb 12 '24 15:02 melvin-bot[bot]

Bump @danieldoglas for review.

isabelastisser avatar Feb 14 '24 16:02 isabelastisser

@isabelastisser Because this is a BE bug. Could you add the label internal here

DylanDylann avatar Feb 14 '24 16:02 DylanDylann

yep, this is internal. Also, this is probably the same root cause for https://github.com/Expensify/App/issues/36494. Closing that issue in favor of this one.

danieldoglas avatar Feb 15 '24 16:02 danieldoglas

Current assignee @DylanDylann is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Feb 15 '24 16:02 melvin-bot[bot]

@isabelastisser I'm unassigning myself, this should be probably a MEDIUM on #vip-vsp

danieldoglas avatar Feb 15 '24 16:02 danieldoglas

@isabelastisser, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 19 '24 15:02 melvin-bot[bot]

Added to VIP, waiting.

isabelastisser avatar Feb 20 '24 02:02 isabelastisser

@isabelastisser @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Feb 21 '24 15:02 melvin-bot[bot]

This issue was included in the VIP project, waiting for an internal engineer assignment.

isabelastisser avatar Feb 22 '24 16:02 isabelastisser

@isabelastisser, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 26 '24 15:02 melvin-bot[bot]

This issue was included in the VIP project, waiting for an internal engineer assignment.

isabelastisser avatar Feb 26 '24 18:02 isabelastisser

@isabelastisser @DylanDylann this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 28 '24 15:02 melvin-bot[bot]

This MIGHT be solved by this WIP PR.

Julesssss avatar Feb 28 '24 15:02 Julesssss

Waiting for this:

This MIGHT be solved by https://github.com/Expensify/Web-Expensify/pull/41055 WIP PR.

isabelastisser avatar Feb 28 '24 16:02 isabelastisser

Not overdue.

isabelastisser avatar Mar 04 '24 18:03 isabelastisser

@isabelastisser @DylanDylann this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] avatar Mar 06 '24 19:03 melvin-bot[bot]

Hi @isabelastisser, I am pretty sure this has been fixed for iOS/Android here. But please test and re-open if you can't reproduce the fix

Julesssss avatar Mar 07 '24 09:03 Julesssss