[$500] IOU - After request deletion, no. of request is not updated in receiver end

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.38 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4289407https://expensify.testrail.io/index.php?/tests/view/4289407 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Launch app
2. Tap on a 1:1 report with user B
3. In other device, login as user B
4. Open 1:1 report with user A
5. As user A, - Tap plus icon and request money ( create 3 money request)
6. As user B- Note 3 money request received from user A
7. As user A- After requesting money thrice, tap IOU to open IOU report page
8. In IOU report page, delete the last request created
9. As user B, in 1:1 page, note amount updated but number of request is not updated
10. Tap IOU and note in IOU report page, only 2 request displayed
11. Again navigate to 1:1 page and note 3 request shown

Expected Result:

After deleting request, amount is updated similarly number of request must also be updated in receiver end

Actual Result:

After deleting request, amount is updated but number of request is not updated in receiver end. For 2 request, it is shown 3 request in IOU preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb9fb0c0a6256318
• Upwork Job ID: 1755344895676690432
• Last Price Increase: 2024-02-07

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01cb9fb0c0a6256318

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot[bot]]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-bills CC @davidcardoza

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After request deletion, no. of request is not updated in receiver end

What is the root cause of that problem?

Problem 1. BE is not pushing the updated childMoneyRequestCount of the report preview report action on request delete Problem 2. Memoization here doesn't consider childMoneyRequestCount https://github.com/Expensify/App/blob/f6ba751301d6a6f4e5faa092e615d49fb02d2746/src/pages/home/report/ReportActionItem.js#L856-L857

What changes do you think we should make in order to solve the problem?

After BE change Add in the memoization

            prevProps.action.childMoneyRequestCount === nextProps.action.childMoneyRequestCount &&

What alternative solutions did you explore? (Optional)

[davidcardoza]

We think that this bug might be related to #vip-bills

Why?

[CortneyOfstad]

@lanitochka17 can you clarify further on why you think this may be related to VIP-Bills?

[CortneyOfstad]

@lanitochka17 bump ^^^ thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@lanitochka17 can you clarify as to why you think this would fit under VIP-Bills/Split?

[melvin-bot[bot]]

@CortneyOfstad, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@CortneyOfstad @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@lanitochka17 bumping this comment. Can you please provide additional context by EOD? Thanks!

[CortneyOfstad]

Bump @lanitochka17

[CortneyOfstad]

Going to keep moving this forward, despite the lack of response, as we cannot sit on this any longer.

This appears to fall into #Vip-Split. Posted it in the room here.

[CortneyOfstad]

@fedirjh it looks like we have a proposal from @FitseTLT here (sorry for the delay in response). If you can provide any feedback by EOD today that will be great.

[fedirjh]

I agree with @FitseTLT's proposal, this requires backend changes, it should update the childMoneyRequestCount . For the front-end, I am not sure if we are going to need these changes, it will depend on the backend changes as there are other fields that may need to be updated.

@CortneyOfstad I think this should go internal.

[melvin-bot[bot]]

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

[fedirjh]

@FitseTLT I don't think this will require any frontend changes. As seen in this line, we check whether the action is updated or not:

https://github.com/Expensify/App/blob/f6ba751301d6a6f4e5faa092e615d49fb02d2746/src/pages/home/report/ReportActionItem.js#L844

[FitseTLT]

@fedirjh Yep this line was the one that confused me I think it can be removed (unnecessary) https://github.com/Expensify/App/blob/88a3ffe9440548d04c32bec2c889b8bb063a29b3/src/pages/home/report/ReportActionItem.js#L904

[melvin-bot[bot]]

@CortneyOfstad @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[CortneyOfstad]

@fedirjh based on the comment here, are we good to move forward with @FitseTLT's proposal?

[fedirjh]

based on the comment https://github.com/Expensify/App/issues/36084#issuecomment-1965259475, are we good to move forward with @FitseTLT's proposal?

@CortneyOfstad No, this issue should be resolved in the backend. I believe that the fix in the backend should suffice.

[CortneyOfstad]

Thank you for the clarification @fedirjh 👍

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[CortneyOfstad]

Hi @dylanexpensify! I am heading OoO and will be back March 11th, so reassigned to have someone keep this moving until I am back. At this stage, we're waiting for internal engineering to pick this up as it is a BE issue. Thanks!

[melvin-bot[bot]]

@CortneyOfstad, @fedirjh, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

Apologies, I've been OOO sick, but am reviewing today!

[melvin-bot[bot]]

@CortneyOfstad @fedirjh @dylanexpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!