[$500] Upon returning from the Referral Section, a black page appears and modals are floating

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

1, Profile 2, Share code 3, Click on "Get $250," then the referral section opens. Click on the back icon from the referral section.

Expected Result:

When we navigate back from the referral section, it should redirect back to the share code section.

Actual Result:

Upon returning from the referral section, a black page appears and modals are floating.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/8a832d1b-d94a-4aa5-b032-b523ea8df335

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0151c67071986a4446
• Upwork Job ID: 1754984369541861376
• Last Price Increase: 2024-02-06

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0151c67071986a4446

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot[bot]]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upon returning from the Referral Section, a black page appears and modals are floating

What is the root cause of that problem?

the referral details component calls theHeaderPageLayout which calls the HeaderWithBackButton component and passes the props to it, so the referral page we don't pass a onBackButtonPressprop to the header page layout, thats why the default back behavior is executed which goes back to the home page

What changes do you think we should make in order to solve the problem?

we need to add onBackButtonPress={Navigation.goBack}

OR we can modify the HeaderWithBackButton itself to onBackButtonPress = () => Navigation.goBack()

[allgandalf]

I guess this is been handled under one issue: https://github.com/Expensify/App/issues/35626

[aimane-chnaif]

I don't see the need of waiting for https://github.com/Expensify/App/issues/35626 (seems like taking a while to fix) while the behavior is weird which requires urgent fix and the solution is straightforward.

[allgandalf]

In that case, i would be available to provide a quick fix to the issue :) @aimane-chnaif , we just need to add the onBackButtonPress={Navigation.goBack} prop and we’re good to go

[aimane-chnaif]

@abzokhattab proposed first. Let's get engineer's thoughts whether to fix or hold.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

@adamgrzybowski is going to sense check whether his solution on the main issue addressing goBack bugs will fix this. Let's hold on making a PR until then!

[adamgrzybowski]

@trjExpensify Should be fixed by https://github.com/Expensify/App/pull/36050

[hayata-suenaga]

The issue is tracked in this GH issue. Closing this in favor of that one 🙇