[$500] Clicking the back button on the Merchant page for an expense takes to a blank page with just the LHN

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @yuwenmemon Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707249292907579

Action Performed:

1. Smartscan a receipt in a workspace chat
2. Open the expense report details page
3. Click on the merchant field
4. Click on back button

Expected Result:

Should land in the expense details page

Actual Result:

Blank page opens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [X] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/3e363967-7132-43ff-8742-5629a9fd64b1

https://github.com/Expensify/App/assets/38435837/8f691838-1c0f-4b58-a63a-461c04c07864

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0199b6cdb65097259b
• Upwork Job ID: 1754982516276056064
• Last Price Increase: 2024-02-06

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0199b6cdb65097259b

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[muas19]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking the back button on the Merchant page for an expense takes to a blank page with just the LHN

What is the root cause of that problem?

We are not passing the onBackButtonPress prop to the HeaderWithBackButton component. https://github.com/Expensify/App/blob/ccad06103b56b1469034658c50f1e6218cc04057/src/pages/EditRequestMerchantPage.js#L50

What changes do you think we should make in order to solve the problem?

Pass the prop with Navigation.dismissModal() <HeaderWithBackButton onBackButtonPress={() => Navigation.dismissModal()} title={translate('common.merchant')} />

What alternative solutions did you explore? (Optional)

n/a

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking the back button on the Merchant page for an expense takes to a blank page with just the LHN

What is the root cause of that problem?

We are missing the back button logic in EditRequestMerchantPage https://github.com/Expensify/App/blob/ccad06103b56b1469034658c50f1e6218cc04057/src/pages/EditRequestMerchantPage.js#L50

What changes do you think we should make in order to solve the problem?

We shoud pass onBackButtonPress={Navigation.goBack} as the prop, like we do in similar pages.

[muas19]

https://github.com/Expensify/App/issues/35965#issuecomment-1930824618 Updated with formatting and typo.

[allgandalf]

Maybe related to: https://github.com/Expensify/App/issues/35626

[trjExpensify]

@adamgrzybowski is going to sense check whether his solution on the main issue addressing goBack bugs will fix this. Let's hold on making a PR until then!

[adamgrzybowski]

@trjExpensify should be fixed by https://github.com/Expensify/App/pull/36050

[hayata-suenaga]

The issue is tracked in https://github.com/Expensify/App/issues/35626. Closing this in favor of that one 🙇