[$500] Thread shows up as "Chat Report" in LHN

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707241155686709

Action Performed:

1. Go to a room on a workspace in account A
2. Initiate a message
3. in the thread tag account B

Expected Result:

Thread title should show up in my LHN

Actual Result:

Chat Report shows up as the thread title in my LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/7401794b-19a8-4d83-8f98-c3520d65fef7

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae85a8837bff1a48
• Upwork Job ID: 1754974220975108096
• Last Price Increase: 2024-02-06

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01ae85a8837bff1a48

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot[bot]]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Tony-MK]

Notes

I think the pusher did not include parentReportActionID in the report. Hence, it could not be classified as a thread but as a Policy Chat Room.

This is because the isChatThread function needs parentActionID and parentReportActionID to return true.

Notice after opening the thread, parentReportActionID gets merged.

Then, the report is recognized as a thread.

Therefore, I believe the most reasonable solution is to inspect the pusher and parentReportActionID alongside parentActionID.

[rushatgabhane]

🎀 👀 🎀 possible internal issue

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[isabelastisser]

Hey @aldo-expensify, any updates here? Thanks!

[aldo-expensify]

Investigating today...

[aldo-expensify]

I'm not sure if I'm getting this issue correctly, but this is what is see:

The user that was mentioned and invited into the room see the "whisper" as the LHN, but this whisper is not really for them so when they open the chat, it is not visible and shouldn't have been used as the "last message" in the LHN

Is this correct? or is there something else that is wrong?

[aldo-expensify]

The reproduction steps seem to be incomplete. For which user does the thread show up as "Chat Report"? that didn't happen to any user in my test.

The testing steps don't mention clicking buttons or inviting a user, do I have to click "Invite them"?

Did the mentioned user have to be a member of the workspace or it doesn't to be one?

[aldo-expensify]

From further testing it seems like the right steps are:

1. Create two accounts accountA and accountB
2. Login with both accounts in different sessions
3. With accountA create a workspace and a room
4. Send a message in the room and create a thread
5. In the thread send a message mentioning the accountB, something like Hello @[email protected]
6. Click "Invite them"
7. See that the chat will show up in accountB's LHN as "Chat Report"

The command that is probably pushing an incomplete event to the invited user is ResolveActionableMentionWhisper. Will continue investigating that tomorrow.

The last message being incorrect in the LHN reported here seems to be an unrelated bug.

[melvin-bot[bot]]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[aldo-expensify]

PR up https://github.com/Expensify/Auth/pull/9933

@Tony-MK 's assessment here was on point, the parentReportActionID was missing in some backend code producing the report structure for onyx. Thanks!

[aldo-expensify]

PR https://github.com/Expensify/Auth/pull/9933 deployed

[aldo-expensify]

Tested well

https://github.com/Expensify/App/assets/87341702/62eab647-17fb-4259-975c-37ef5cb9b983